Feat: Added 2 drawer screens #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderbiscuit
requested changes
Apr 11, 2022
app/src/main/java/com/goldenraven/padawanwallet/ui/drawer/RecoveryPhraseScreen.kt
Show resolved
Hide resolved
app/src/main/java/com/goldenraven/padawanwallet/ui/drawer/SendCoinsBackScreen.kt
Show resolved
Hide resolved
|
|
||
| fun copyToClipboard(context: Context, scope: CoroutineScope, snackbarHostState: SnackbarHostState) { | ||
| val clipboard: ClipboardManager = context.getSystemService(Context.CLIPBOARD_SERVICE) as ClipboardManager | ||
| val clip: ClipData = ClipData.newPlainText("Copied address", context.getString(R.string.send_coins_back_address)) |
There was a problem hiding this comment.
On my device the end of the address is not shown, but there is also no real indication that a part of it is missing. It's not a big deal because you click/copy anyway the right string, but I'm wondering if you'd mind making the font a bit smaller so that it shows the full address on more devices.
There was a problem hiding this comment.
Maybe not a long-term solution, but for now at least is a bit better than just cutting the address on most devices.
|
Awesome stuff 🔥 🔥. Also congrats on opening PR #200!!! |
|
Updated the commit to remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added drawer screens for
RecoveryPhraseScreen.ktandSendCoinsBackScreen.kt.Standardized the animations for every drawer screen.
In the
SendCoinsBackScreen.ktI have used the general snackbar but it can be changed later on.