Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed hard-coded strings from IntroFragment.kt #158

Merged

Conversation

dhruv-1001
Copy link
Contributor

Fixes #155

Strings migrated to strings.xml as:

<string name="intro_dialog_message">...</string>
<string name="intro_dialog_title">...</string>
<string name="intro_dialog_positive">...</string>
<string name="intro_dialog_negative">...</string>

@thunderbiscuit
Copy link
Owner

Awesome! Thanks a bunch.

Just a quick fix: your commit message should follow the convention I'm using, which is:

  1. Start with a tag, capitalized (in your case Refactor:)
  2. Present-tense statement answering the question: "What does this commit do?", also capitalized

So for this one it would look something like this: Refactor: Move hard-coded strings from IntroFragment to strings.xml

Otherwise it's ready to merge!

@thunderbiscuit
Copy link
Owner

If you need help with fixing the message and force pushing to the PR let me know!

@dhruv-1001
Copy link
Contributor Author

Thanks for the suggestion, I hope it's alright now.

@thunderbiscuit
Copy link
Owner

Yep thanks for the contribution, and welcome to Padawan!

@thunderbiscuit thunderbiscuit merged commit 6748499 into thunderbiscuit:master Mar 1, 2022
@dhruv-1001 dhruv-1001 deleted the remove-hard-coded-strings branch March 1, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove hard-coded strings in IntroFragment
2 participants