Skip to content

Conversation

@ValuedMammal
Copy link

Description

This change attempts to do the following

  • Simplify Balance computation by reusing logic from filter_chain_unspents.
  • Add an outpoints parameter to give the caller more control of the outputs to consider.
  • Rewrite trust_predicate and encapsulate the trust definition in Wallet::is_tx_trusted.

We also discussed deferring more of the logic to CanonicalView::balance once that becomes available in bdk_wallet.

Builds on bitcoindevkit#318

@thunderbiscuit thunderbiscuit merged commit 3b7d142 into thunderbiscuit:feature/multi-keychain-wallet Nov 4, 2025
14 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19080109508

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 42 of 50 (84.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 69.091%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/wallet/mod.rs 42 50 84.0%
Files with Coverage Reduction New Missed Lines %
src/wallet/mod.rs 3 49.04%
Totals Coverage Status
Change from base Build 19012656117: -0.1%
Covered Lines: 3297
Relevant Lines: 4772

💛 - Coveralls

@ValuedMammal ValuedMammal deleted the 2025_11_4_feature_multi_keychain_wallet branch November 4, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants