Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dim read posts setting not being applied for card view #1530

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This PR fixes an issue where disabling "Dim Read Posts" was not being respected when using card view. Additionally, I've applied a bit more margin between each metadata widget to improve general readability.

Note: In #1510, I removed the spacing: 8.0 from the Wrap widget, and moved the spacing to the margins of each metadata widget. However, I only applied a margin of EdgeInsets.only(right: 4.0) when it should've been EdgeInsets.only(right: 8.0) to keep the same spacing.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-08-13.at.15.56.53.mp4

Padding Changes

Before After
simulator_screenshot_48F67986-E9D7-4B2D-8E1F-4B30BF629483 simulator_screenshot_1E803391-CBE8-4730-9B70-D5E4483CADB9

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@micahmo
Copy link
Member

micahmo commented Aug 13, 2024

LGTM!

BTW, it's not related to these changes, but does the new combined up/down arrow and vote count change in response to being dimmed, even when colored to indicate a vote? I couldn't tell but it kinda looked like it didn't.

@hjiangsu
Copy link
Member Author

BTW, it's not related to these changes, but does the new combined up/down arrow and vote count change in response to being dimmed, even when colored to indicate a vote? I couldn't tell but it kinda looked like it didn't.

I believe so? It's a bit hard to see due to compression, but both the card/compact views share the same logic so it should be applied!

image image
image image

@hjiangsu hjiangsu merged commit cc8c44a into develop Aug 14, 2024
1 check passed
@hjiangsu hjiangsu deleted the fix/dim-read-posts-card branch August 14, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants