Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't make subscriptions default feed type in gest mode #1490

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Jul 11, 2024

Pull Request Description

This PR removes the option to set "Subscribed" as the default feed type for guest mode, since that is not a valid option. I also added a migration in case anyone had that set before.

Note that, although we did allow "Subscribed" as a default option, it didn't seem to actually cause a problem. Having "Subscribed" selected from a user account also didn't cause a problem with switching to an anonymous instance.

Issue Being Fixed

Issue Number: #1487

Screenshots / Recordings

This is just a screen recording to show that I couldn't reproduce any issue with the way things are now (aside from potential confusion).

qemu-system-x86_64_KR1Lf74moO.mp4

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 6cfb84f into thunder-app:develop Jul 13, 2024
1 check passed
@micahmo micahmo deleted the fix/subscribed-guest-mode branch July 13, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants