Can't make subscriptions default feed type in gest mode #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR removes the option to set "Subscribed" as the default feed type for guest mode, since that is not a valid option. I also added a migration in case anyone had that set before.
Note that, although we did allow "Subscribed" as a default option, it didn't seem to actually cause a problem. Having "Subscribed" selected from a user account also didn't cause a problem with switching to an anonymous instance.
Issue Being Fixed
Issue Number: #1487
Screenshots / Recordings
This is just a screen recording to show that I couldn't reproduce any issue with the way things are now (aside from potential confusion).
qemu-system-x86_64_KR1Lf74moO.mp4
Checklist
semanticLabels where applicable for accessibility?