Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove page scroll animation when switching between bottom navigation items #1402

Merged
merged 1 commit into from
May 31, 2024

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented May 31, 2024

Pull Request Description

This PR removes the page animation that occurs when switching between the feed, search, account, inbox, and setting pages. There are a few reasons why I opted to remove this page animation:

  • When switching between pages, there's no obvious way to remove the visual glitch mentioned in Buggy navigation bar animation #1257. The underlying issue is that the scroll animation loads each page briefly, so the behaviour that the bottom nav bar experiences is correct (since we're actually navigating through those pages)
  • Because the animation technically loads each page as it scrolls through them, the logic within each page also gets briefly triggered. This means that if I navigate from the feed to the settings page, each page in between will be loaded (and the logic for each page will be triggered). As a side effect, this causes some additional network requests even when they're not required.
  • The animation technically does not meet MD3 guidelines. This is not a large issue, but it would be nice to match those guidelines whenever possible

For those reasons mentioned above, I think it would be best to remove this animation. Thoughts on this change @micahmo?

Issue Being Fixed

Issue Number: #1257

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally agree! This seems to follow the pattern that most apps with a bottom nav bar use.

@hjiangsu hjiangsu merged commit 120f28e into develop May 31, 2024
1 check passed
@hjiangsu hjiangsu deleted the feature/remove-page-switch-animation branch May 31, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants