Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS build errors #1401

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Fix macOS build errors #1401

merged 1 commit into from
Jun 1, 2024

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This PR fixes some issues with Thunder not building properly on macOS. This is mainly due to unmet requirements for some packages (minimum macOS version), and issues with regards to flavors.

  • Wrapped DeepLinksCubit to only run on Android and iOS devices as it's not supported on macOS (and likely other desktop variants)
  • Upped macOS version from 10.14 to 11.0
  • Added development and production flavors to macOS build

Issue Being Fixed

Issue Number: N/A - this is mainly so that I can iterate quickly without using an emulator/simulator

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu hjiangsu merged commit 93d7588 into develop Jun 1, 2024
1 check passed
@hjiangsu hjiangsu deleted the misc/fix-macos-build branch June 1, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant