Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not render images too wide in spoiler body #1396

Merged
merged 1 commit into from
May 30, 2024
Merged

Do not render images too wide in spoiler body #1396

merged 1 commit into from
May 30, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented May 29, 2024

Pull Request Description

This is a super small PR which fixes an issue where images would be rendered too wide in spoiler blocks.

Before After
image image

hjiangsu
hjiangsu approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@hjiangsu hjiangsu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This will go into the next release after 0.4.0. I've already submitted 0.4.0 to the app stores for approval!

@hjiangsu hjiangsu added this to the 0.5.0 milestone May 30, 2024
@hjiangsu hjiangsu merged commit 3743c92 into thunder-app:develop May 30, 2024
1 check passed
@micahmo micahmo deleted the fix/image-in-spoiler branch May 30, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@micahmo @hjiangsu