-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few post sheet improvements #1391
A few post sheet improvements #1391
Conversation
Thanks for working on the dismiss for blocked communities and users, it looks great! I just have one question:
Does this only apply to the current post? (e.g., If I have multiple posts from a given community in the feed, but I subscribe to a community via a post card action, does the subscribed state apply to all other posts with that community?) If not, then maybe a better way to handle this is to display a snackbar message when the subscribed action is successfully performed. I think the user will mostly understand that they have to refresh the feed to see that subscribed status. |
Ahh, good catch, it did only apply to the given post. I replaced the update with a snackbar! The only other options I could think of would be to (a) iterate through the whole feed and update all matching posts (might not be too bad) or (b) fetch the status every time opening the bottom sheet (wouldn't be great). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor comments!
Should be good now! |
Pull Request Description
This PR improves the post bottom sheet in a few ways (followup to #1199).
Demo - Block
block-community-dismiss.mp4