Improve creating posts/comments

[micahmo]

Pull Request Description

This PR includes a few changes related to creating posts/comments.

• Improve selectability of posts/comments when replying.
  • I found that the MarkdownWidget's selectable flag doesn't support selecting across multiple paragraphs, so I wrapped it in a SelectableRegion which is more flexible.
  • I added the ability to view the raw contents of a post/comment when replying. This gives you the ability to quote the original poster while preserving their markdown formatting within your quote.
    • The next step in my plan is to automatically populate the post/comment selection into the comment editor when pressing the "quote" markdown option. This will make it even easier to quote something (without copying/pasting) and to optionally preserve the markdown formatting.
• Made the new post preview look more like the new comment preview.

Hide whitespace

Screenshots / Recordings

qemu-system-x86_64_2nQKIqtlHs.mp4

[hjiangsu]

I found that the MarkdownWidget's selectable flag doesn't support selecting across multiple paragraphs, so I wrapped it in a SelectableRegion which is more flexible.

This is an aside, but we might be able to completely remove the selectable parameter in MarkdownWidget if that's the case! I believe we initially used it in the old comment page only (but check to see if there are any existing references to it)

I'm also wondering if we can adjust the positioning of the view source button! From the demo, it feels like it's lumped up with the metadata information which might reduce discovery of the feature.

Some ideas:

• We can play around with padding to make it feel like it's not part of the metadata
• Make a new section under the preview for additional actions (we could even potentially add another action to just copy the whole contents)

These are just some initial points. I haven't taken a look at the implementation yet but will do so soon! 😄

[micahmo]

This is an aside, but we might be able to completely remove the selectable parameter in MarkdownWidget if that's the case! I believe we initially used it in the old comment page only (but check to see if there are any existing references to it)

Good idea! I've removed it from CommonMarkdownBody, but not from ExtendedMarkdownBody as that maps to ExtendedMarkdownWidget which maps to MarkdownWidget which comes from a package, and I figured there's no need to hide legitimate parameters via our wrapper widgets.

I'm also wondering if we can adjust the positioning of the view source button!

Sure, I'll play around with it!

[micahmo]

Alright, I added a divider, and also a copy option. Thoughts?

qemu-system-x86_64_VS90Yj4YzL.mp4

[hjiangsu]

Alright, I added a divider, and also a copy option

I think that looks better! Thanks for making the change 😄

[hjiangsu]

Just did a quick review of this and had some points of discussion!

[hjiangsu]

Do you think we need to apply the SelectableRegion here, or would it be more suited as part of the create comment page? (same thing with the comment SelectableRegion)

I guess the main discussion point is whether or not we're expecting to make the post selectable in other areas outside of the create comment page. We already have a way to copy post/comments from #1327!

[micahmo]

I originally put the SelectableRegion around the whole PostSubview and CommentContent widgets, but that had a couple of weird side-effects. For one, I couldn't see the drag handles or the selection highlight color. But the bigger issue is that it allows everything in those widgets to be selectable, including the metadata, which I thought was weird! It seemed to be behave much better when wrapped directly around the CommonMarkdownBody, and I don't think it causes any harm, even if this is the only place we use it. Thoughts?

[hjiangsu]

Ahh okay, you make a good point about allowing metadata to be selected! We'll keep it as it!

[micahmo]

This should be ready to go, depending on your thoughts on the unresolved comment!