Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fab transparency and exit fade #1357

Merged
merged 3 commits into from
May 11, 2024

Conversation

CTalvio
Copy link
Collaborator

@CTalvio CTalvio commented May 7, 2024

Pull Request Description

Removes redundant ModalBarrier and fixes the FAB exit animation.

Both ModalBarrier would be present in the main feed, stacking their colors. Using the ModalBarrier under AnimatedOpacity also breaks the FAB exit animation, so i separated them out in the stack and used a Container under an IgnorePointer to accomplish the darkening.

Issue Being Fixed

Solid color FAB background only in main feed, instant exit fade as the instantly removed ModalBarrier cannot animate.

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I haven't ran it physically yet but from what you mentioned on Matrix, seems to address the initial concerns

@hjiangsu hjiangsu merged commit 8c95453 into thunder-app:develop May 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants