Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few notifications-related improvements #1355

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented May 7, 2024

Pull Request Description

This PR includes a couple of miscellaneous changes related to notifications. (Don't feel the need to fast-track this as it shouldn't be related to any bugs.)

  • Use the LoadingPage while setting up the notifications page after responding to a tap (since it can take a while to load everything).
  • Ensure that the optional profile picture on the main feed doesn't reload for temporary accounts by respecting the reload flag.
  • Enlarge the thunder icon displayed in the notification bar to match other apps' sizes.

Icon Size (look at the top)

Before After
image image

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm not too sure if it affects things, but have you tested this change out with a profile/release build?

The main thing to look out for is if the icon appears properly on those modes since we adjusted the icon location (the build processes might not include the new icon assets in release)

@micahmo
Copy link
Member Author

micahmo commented May 13, 2024

I just tested both debug and profile as well as the production and development flavors, and everything looks good!

(I can't make a release build due to a signing error and I never looked into that. Probably I'd have to supply my own signing key. But I've been able to get away with profile. 😊)

@hjiangsu
Copy link
Member

If it works on profile mode, then I believe it should work on release builds as well!

@hjiangsu hjiangsu merged commit f27f7d8 into thunder-app:develop May 13, 2024
1 check passed
@micahmo micahmo deleted the feature/miscellaneous-notifications-improvements branch May 13, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants