Disable Thunder's edge swipe to go back on Android #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahmo
approved these changes
May 3, 2024
There was a problem hiding this comment.
Tested on a physical device and it seems fine!
Although I'm still a bit unsure as to the cause of this bug because the page showed in the bug demo wasn't created with SwipeablePageRoute (and I verified that I can't use full-page swipe on my device, regardless of the setting).
Ahh yeah you're right - I wasn't able to reproduce that issue either. I think this is still a step in the right direction! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR disables Thunder's edge swipe to go back gesture when
Full Swipe Gesturesis disabled. This does not affect Android's system navigation gestures. For iOS, the edge swipe to go back will always be enabled regardless of the setting toggle because that's the primary way to navigate back on iOS devices.@micahmo if you could test this out on a physical device and let me know, that would be great! I tested it on an emulator and it seems to be working as expected there.
Issue Being Fixed
Issue Number: #1340
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?