Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with tablet mode images and full-height images #1334

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This PR fixes a regression where having tablet mode and full height images would cause borders to show on certain images.

Issue Being Fixed

Issue Number: #1330

Screenshots / Recordings

The recordings are too big for GitHub, so I've attached externals links

Before (notice how some images are squished + contain a border)
https://files.catbox.moe/qo3v11.webm

After
https://files.catbox.moe/xflwxy.webm

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 02363f0 into develop Apr 29, 2024
1 check passed
@hjiangsu hjiangsu deleted the fix/tablet-mode-images branch April 29, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants