Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an option to hide thumbnails in feed #1302

Merged

Conversation

iparks99
Copy link
Contributor

@iparks99 iparks99 commented Apr 13, 2024

Pull Request Description

Added a toggle option to Post Compact View Settings to hide thumbnails entirely from the feed. This does not affect images in post bodies.

Potential To Do:

  • Hidden thumbnails should be replaced with a gray box indicating the type of post (text, image, or link)
  • An option to hide images in post bodies

Issue Being Fixed

Not loading images in the feed would be advantageous to anyone with limited data, or just preferring a text-only feed.

Issue Number: #352

Screenshots / Recordings

image
image

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu
Copy link
Member

Thanks for doing this @iparks99! I just have a discussion point for this.

It might be worth it to extend this to both compact/card views. For compact mode, you already have it implemented which is great. I'm thinking for the card view, we can replace the image with just a link (see the image for reference). The link can then distinguish the type of media based on the leading icon (link, image, video)

image

If we do go forward with this, we can move the setting to the general setting area in appearance (Appearance > Posts > Feed Settings).

@micahmo do you have any thoughts on this idea?

@micahmo
Copy link
Member

micahmo commented Apr 17, 2024

@micahmo do you have any thoughts on this idea?

Sorry I hadn't looked too closely at this yet since it was a draft. I do like your idea of making this a general setting for all post types and using the link placeholder to indicate the media type in card view. As long as the link placeholder can act as the media preview in the sense that tapping it will show the media (if applicable). And we definitely need something similar to show the media type in condensed view as well.

@iparks99 iparks99 force-pushed the feature/compact-mode-hide-thumbnails branch from f4e4158 to cb96e26 Compare April 19, 2024 20:09
@iparks99
Copy link
Contributor Author

Thanks for the feedback @hjiangsu and @micahmo! I've done the following based on your feedback:

  • Moved the toggle option from Compact View Settings to Feed Settings
  • Show link information in Card View
  • Card View link information icon changes depending on media type
  • Card View link information shows the image preview on tap

image

hide-thumbnails-demo-2024-04-19_16.18.45.mp4

@iparks99 iparks99 marked this pull request as ready for review April 19, 2024 20:22
Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple small comments, but otherwise LGTM. Nice work!!

lib/l10n/app_en.arb Outdated Show resolved Hide resolved
lib/shared/media_view.dart Outdated Show resolved Hide resolved
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor code documentation changes. Otherwise, LGTM!

lib/settings/pages/post_appearance_settings_page.dart Outdated Show resolved Hide resolved
lib/shared/link_information.dart Show resolved Hide resolved
@iparks99 iparks99 changed the title Added an option to hide thumbnails in compact feed Added an option to hide thumbnails in feed Apr 24, 2024
@hjiangsu hjiangsu merged commit da3aec2 into thunder-app:develop Apr 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants