Added an option to hide thumbnails in feed

[iparks99]

Pull Request Description

Added a toggle option to Post Compact View Settings to hide thumbnails entirely from the feed. This does not affect images in post bodies.

Potential To Do:

• Hidden thumbnails should be replaced with a gray box indicating the type of post (text, image, or link)
• An option to hide images in post bodies

Issue Being Fixed

Not loading images in the feed would be advantageous to anyone with limited data, or just preferring a text-only feed.

Issue Number: #352

Screenshots / Recordings

Checklist

• Did you update CHANGELOG.md?
• Did you use localized strings where applicable?
• Did you add semanticLabels where applicable for accessibility?

[hjiangsu]

Thanks for doing this @iparks99! I just have a discussion point for this.

It might be worth it to extend this to both compact/card views. For compact mode, you already have it implemented which is great. I'm thinking for the card view, we can replace the image with just a link (see the image for reference). The link can then distinguish the type of media based on the leading icon (link, image, video)

If we do go forward with this, we can move the setting to the general setting area in appearance (Appearance > Posts > Feed Settings).

@micahmo do you have any thoughts on this idea?

[micahmo]

@micahmo do you have any thoughts on this idea?

Sorry I hadn't looked too closely at this yet since it was a draft. I do like your idea of making this a general setting for all post types and using the link placeholder to indicate the media type in card view. As long as the link placeholder can act as the media preview in the sense that tapping it will show the media (if applicable). And we definitely need something similar to show the media type in condensed view as well.

[iparks99]

Thanks for the feedback @hjiangsu and @micahmo! I've done the following based on your feedback:

• Moved the toggle option from Compact View Settings to Feed Settings
• Show link information in Card View
• Card View link information icon changes depending on media type
• Card View link information shows the image preview on tap

hide-thumbnails-demo-2024-04-19_16.18.45.mp4

[micahmo]

I left a couple small comments, but otherwise LGTM. Nice work!!

[hjiangsu]

Just some minor code documentation changes. Otherwise, LGTM!