Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve missing post message #1291

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Apr 10, 2024

Pull Request Description

This is a small PR which improves the error messaging when we can't find a post. This can happen if a post is deleted after the feed is loaded, for example.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

delete-before.mp4

After

delete-after.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit cece3b1 into thunder-app:develop Apr 10, 2024
1 check passed
@micahmo micahmo deleted the feautre/improve-couldnt-find-post branch April 10, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants