Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor post metadata and user/community chips #1281

Merged
merged 6 commits into from
Apr 18, 2024

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Apr 6, 2024

Pull Request Description

This PR refactors the post view's metadata (comment count + date/time), and the post view username/community information.

  • Removes the old PostCardMetaData widget
  • Refactors PostViewMetaData to use the same widgets as the post card (for comment count, date/time)
  • Refactored the logic for determining special users and colours.
  • New widgets have been created for user/community chips which apply special colours and icons (similar to how comment header and post page show a user's special status)
  • Fixed an issue where the full name widgets were not applying the proper instance colour - separate PR for this Fix user/community instance colour not being applied properly #1282

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu hjiangsu marked this pull request as ready for review April 10, 2024 17:11
@hjiangsu hjiangsu changed the title Draft: Refactor post metadata and user/community chips Refactor post metadata and user/community chips Apr 10, 2024
@hjiangsu
Copy link
Member Author

@micahmo I believe this should be good to go now if you want to take a look at it!

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested but the code LGTM! Seems like a very nice refactoring! 😊

@hjiangsu
Copy link
Member Author

Sounds good! I'll go ahead and merge this in (unfortunately, it might cause some merge conflicts on some other PRs but I'm hoping its not too much of a hassle 😅)

@hjiangsu hjiangsu merged commit 574c285 into develop Apr 18, 2024
1 check passed
@hjiangsu hjiangsu deleted the refactor/post-metadata branch April 18, 2024 17:25
@micahmo
Copy link
Member

micahmo commented Apr 18, 2024

Yes I think this will at least affect @iparks99 in #1300. But maybe the avatar could be made part of the UserChip?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants