Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with deferred comments #1107

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Feb 1, 2024

Pull Request Description

Since LemmyNet/lemmy#3965 was done, I thought we wouldn't have any more issues loading nested comments, but I still do every now and then. I tracked it down to a section of code I had added as error handling. To be honest, the conditions I was checking make sense. It's whether the number of comments we've loaded are more than the total reported by Lemmy. And in fact, in the scenario I'm testing, we do seem to have loaded all the comments by number. So I'm not sure exactly what's going on. But by removing the artificial exception, we are able to successfully load the deferred comments. Therefore, I'm going to remove this exception. We should have time in the nightlies to see if this brings back the infinite spinner at all.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

deferred_comments_before.mp4

After

deferred_comments_after.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for double checking this issue!

@hjiangsu hjiangsu merged commit 33c8439 into thunder-app:develop Feb 5, 2024
1 check passed
@micahmo micahmo deleted the fix/deferred-comments branch February 5, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants