Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Since LemmyNet/lemmy#3965 was done, I thought we wouldn't have any more issues loading nested comments, but I still do every now and then. I tracked it down to a section of code I had added as error handling. To be honest, the conditions I was checking make sense. It's whether the number of comments we've loaded are more than the total reported by Lemmy. And in fact, in the scenario I'm testing, we do seem to have loaded all the comments by number. So I'm not sure exactly what's going on. But by removing the artificial exception, we are able to successfully load the deferred comments. Therefore, I'm going to remove this exception. We should have time in the nightlies to see if this brings back the infinite spinner at all.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Before
deferred_comments_before.mp4
After
deferred_comments_after.mp4
Checklist
semanticLabel
s where applicable for accessibility?