Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where feed FAB can be triggered on other pages #1085

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This is a small PR which fixes an issue where the feed FAB can be triggered from another screen. This is because the FAB is still on screen, but is just invisible.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Does the FAB still appear on communities that are opened from another page?

@hjiangsu
Copy link
Member Author

Does the FAB still appear on communities that are opened from another page?

It still works when navigating to a community on a new page since that uses a separate feed FAB!

@hjiangsu hjiangsu merged commit cbb3334 into develop Jan 25, 2024
1 check passed
@hjiangsu hjiangsu deleted the fix/feed-fab-interact branch January 25, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants