Fix an issue with loading favorites on startup #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahmo
commented
Jan 22, 2024
Comment on lines
+46
to
+48
| await _getAccountInformation(GetAccountInformation(), emit); | ||
| await _getAccountSubscriptions(GetAccountSubscriptions(), emit); | ||
| await _getFavoritedCommunities(GetFavoritedCommunities(), emit); |
There was a problem hiding this comment.
The problem here is that adding these things as events causes them to execute asynchronously, which creates a race condition (specifically because calculating the favorites requires having all of the subscriptions first). By specifically invoking and awaiting, we ensure that everything executes in the right order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR fixes an issue where initial usage of things like the community autocomplete and search page do not include favorites until the drawer is opened once.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Before
favorite_before.mp4
After
favorites_after.mp4
Checklist
semanticLabels where applicable for accessibility?