Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a notification page to display individual messages #1069

Merged
merged 5 commits into from
Jan 22, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Jan 19, 2024

Pull Request Description

This PR is a followup to the recent notifications PR, which adds the ability to navigate directly to a specific reply from a notification. This is accomplished by pushing a new page onto the navigation stack, which is especially useful when the user has already navigated in the app to another page. Previously, opening a notification would scroll to the Inbox tab, but if there were another page open, that action would not be visible. Now a new page is pushed on top.

If the user clicks on a group notification, the page will show all unread replies. If the user clicks on a specific reply, the page will show only that reply (similar to opening an email). Also note that it will show that reply whether it is unread or not (in case the user happened to mark it read outside of Thunder). From there, the user can perform all the standard actions with the reply.

Review without whitespace.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Opening group notification

qemu-system-x86_64_Yu9KuTiWRZ.mp4

Opening single notification

qemu-system-x86_64_troMOP0FlS.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just a couple of comments.

I'll trust that it works on Android since I can't test it out myself!

lib/thunder/pages/notifications_pages.dart Outdated Show resolved Hide resolved
lib/utils/notifications.dart Outdated Show resolved Hide resolved
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@hjiangsu hjiangsu merged commit efe5c7f into thunder-app:develop Jan 22, 2024
1 check passed
@micahmo micahmo deleted the feature/notification-page branch January 22, 2024 20:45
@micahmo micahmo mentioned this pull request Jan 23, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants