Refactor local settings to use localization strings #1045
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds a way to get a localized string based on a key/string. Flutter does not support mirrors, so this approach is more manual. It requires us to create a map between the key and the localization string. The following changes were made:
label
tokey
in LocalSettings enum. This was done because it makes more semantic sense.getLocalSettingLocalization
. This function takes in a key, and outputs the associated localization string.Note: for each new setting we add, we also need to add in the corresponding entry into the map so that it can be associates with the proper localization string.
Reference: https://stackoverflow.com/questions/55445624/how-to-get-a-property-by-this-name-in-string
Issue Being Fixed
This relates to #1036 and hopefully provides a way to allow for localized strings for the search functionality.
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabel
s where applicable for accessibility?