Change sizes of avatars #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL |
danoc
requested changes
Jun 10, 2019
There was a problem hiding this comment.
The change LGTM. Let's wait to merge until we've met with @jonpkerwin.
danoc
requested changes
Jun 11, 2019
| } | ||
|
|
||
| .rootSmall { | ||
| .rootXSmall { |
There was a problem hiding this comment.
The class rename seems to not work nicely here:
https://deploy-preview-296--thumbprint.netlify.com/components/avatar/react/#example-extra-small
Haven't dug into this, but it may be related to Gatsby's CSS modules implementation. I've had to work around this bug in the past: gatsbyjs/gatsby#5458
|
Is it using these font-sizes? |
|
Both good catches! Font size and xsmall typo fixed 🙇 |
|
This looks good! Let's wait to merge until the codemods are ready to go. |
danoc
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.