Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ppo discrete test script more general #418

Merged
merged 1 commit into from
Aug 15, 2021

Conversation

Trinkle23897
Copy link
Collaborator

also fix #249 (comment)

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2021

Codecov Report

Merging #418 (4838dc3) into master (bba30f8) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
+ Coverage   94.63%   94.69%   +0.05%     
==========================================
  Files          57       57              
  Lines        3749     3749              
==========================================
+ Hits         3548     3550       +2     
+ Misses        201      199       -2     
Flag Coverage Δ
unittests 94.69% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/policy/modelfree/ppo.py 93.93% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bba30f8...4838dc3. Read the comment docs.

@Trinkle23897 Trinkle23897 merged commit 5b7732a into thu-ml:master Aug 15, 2021
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test reward never change when implement PPO on Acrobot-v1 (Probably) Unfair Speed Comparison
2 participants