remove/useless-label - #1298
Conversation
mhluongo
left a comment
There was a problem hiding this comment.
👍, leaving it to @ngrinkevich for another review and merge.
Keep em coming @decanus 😉
|
@mhluongo only got around to fixing it here, should get around to doing it everywhere else. |
|
The labels aren't useless, they're how the struct gets assembled on the Go side, which is why the Go build failed in this case. As well, pulling names out of code and adding them to the docs isn't something we're likely to be doing. If a name is in the docs, it should be in the code unless there's no way to specify it there. Code is best considered the ultimate source of truth in these matters. With that said, thanks for adding the multiple |
removes useless labels, change the return label to be compliant with argotorg/solidity#7534