Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development umbrel #129

Merged
merged 31 commits into from
Feb 28, 2023
Merged

Development umbrel #129

merged 31 commits into from
Feb 28, 2023

Conversation

0oM4R
Copy link
Contributor

@0oM4R 0oM4R commented Feb 16, 2023

grid3_Umbrel
related issue:

please check tf umbrel readme

in this image :

  • Umbrel
  • Docker
  • Docker-compose
  • include preinstalled, openssh-client, yq, openssh-server, curl, iproute2, python3, and some other packages.
  • ufw with restricted rules applied.
  • zint

flist: https://hub.grid.tf/kassem.3bot/0om4r-umbrel-1.0.0.flist

required env :

  • SSH_KEY: User SSH public key.
  • USERNAME: this will be used in registration to Umbrel dashboard.
  • PASSWORD: this will be used in registration, and login to Umbrel dashboard.

optional env:

  • UMBREL_DISK: the disk where the umbrel will be installed and store its data

Copy link
Member

@sameh-farouk sameh-farouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look and suggested some changes.
also, there are a few issues I faced when tried to build and deploy the list to give it a quick test.
1- Can't ssh to the VM, I didn't check what is could be wrong. connection refused.
2- Sent USERNAME and PASSWORD as ENVs per the docs but still asking me to register an account when I visit the root URL thought this process should be automated.

tfgrid3/umbrel/README.md Outdated Show resolved Hide resolved
tfgrid3/umbrel/dockerfile Outdated Show resolved Hide resolved
tfgrid3/umbrel/dockerfile Outdated Show resolved Hide resolved
tfgrid3/umbrel/dockerfile Outdated Show resolved Hide resolved
tfgrid3/umbrel/dockerfile Outdated Show resolved Hide resolved
tfgrid3/umbrel/dockerfile Outdated Show resolved Hide resolved
tfgrid3/umbrel/dockerfile Outdated Show resolved Hide resolved
tfgrid3/umbrel/dockerfile Outdated Show resolved Hide resolved
tfgrid3/umbrel/dockerfile Outdated Show resolved Hide resolved
tfgrid3/umbrel/dockerfile Outdated Show resolved Hide resolved
@0oM4R
Copy link
Contributor Author

0oM4R commented Feb 19, 2023

I had a look and suggested some changes. also, there are a few issues I faced when tried to build and deploy the list to give it a quick test. 1- Can't ssh to the VM, I didn't check what is could be wrong. connection refused. 2- Sent USERNAME and PASSWORD as ENVs per the docs but still asking me to register an account when I visit the root URL thought this process should be automated.

@sameh-farouk
ssh issue should be resolved, please make sure that the password is 12 char or more and I will add this note to readme

@0oM4R
Copy link
Contributor Author

0oM4R commented Feb 26, 2023

all the comments resolved, I will update the pr description with the new edits

@0oM4R
Copy link
Contributor Author

0oM4R commented Feb 26, 2023

some noes about the changes

  • zinit config
    the umbrel installation is now on running, and you can provide a disk for it, this is done by zinit config, which runs umbrel-installition
    some manipulation to the start script is done here to enable ipv6 and make the script pull the docker-compose images instead of running them

  • zinit start

    this process runs

    • umbrel-start script,
      • which checks if the reboot file exists and runs the umbrel stop script
      • runs a modified version umbrel start script, this modification is made to avoid some tor-server and installed apps relate issue
    • move to umbrel path and run docker-compose up to make it monitored by zinit with no-recreate as the start script make them up already

@0oM4R 0oM4R requested a review from sameh-farouk February 26, 2023 16:03
tfgrid3/umbrel/dockerfile Outdated Show resolved Hide resolved
tfgrid3/umbrel/scripts/yq.sh Outdated Show resolved Hide resolved
tfgrid3/umbrel/zinit/config.yaml Show resolved Hide resolved
tfgrid3/umbrel/scripts/umbrel-start.sh Show resolved Hide resolved
tfgrid3/umbrel/README.md Outdated Show resolved Hide resolved
tfgrid3/umbrel/dockerfile Outdated Show resolved Hide resolved
tfgrid3/umbrel/dockerfile Show resolved Hide resolved
@0oM4R 0oM4R requested a review from sameh-farouk February 28, 2023 12:57
@0oM4R 0oM4R merged commit b4dcbd6 into development Feb 28, 2023
@0oM4R 0oM4R deleted the development_umbrel branch February 28, 2023 14:04
@xmonader xmonader modified the milestone: 3.15.x Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants