Resolve Actions deprecations #1316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenchy64
requested review from
gbuisson,
yogsototh,
msprunck,
ereteog,
turbodog99,
rplevy,
agzam,
wandersoncferreira,
DeLaGuardo,
obarbeau,
marioaquino and
safi
as code owners
brookeswanson
approved these changes
Oct 27, 2022
Comment on lines
+32
to
+36
| (let [github-output-file (File/createTempFile "github-output" nil) | ||
| {:keys [grab-history utils]} (th/mk-utils {"GITHUB_OUTPUT" (.getPath github-output-file)}) | ||
| _ (sut/set-output utils "foo" "bar") | ||
| _ (is (empty? (grab-history))) | ||
| _ (is (= "foo=bar\n" (slurp github-output-file)))])) |
There was a problem hiding this comment.
Suggested change
| (let [github-output-file (File/createTempFile "github-output" nil) | |
| {:keys [grab-history utils]} (th/mk-utils {"GITHUB_OUTPUT" (.getPath github-output-file)}) | |
| _ (sut/set-output utils "foo" "bar") | |
| _ (is (empty? (grab-history))) | |
| _ (is (= "foo=bar\n" (slurp github-output-file)))])) | |
| (let [github-output-file (File/createTempFile "github-output" nil) | |
| {:keys [grab-history utils]} (th/mk-utils {"GITHUB_OUTPUT" (.getPath github-output-file)})] | |
| (sut/set-output utils "foo" "bar") | |
| (is (empty? (grab-history))) | |
| (is (= "foo=bar\n" (slurp github-output-file))))) |
Can we pull these out of the body of the let?
| (set-output | ||
| n | ||
| (json/generate-string v {:pretty false}))) | ||
| (set-output utils n (json/generate-string v {:pretty false}))) |
There was a problem hiding this comment.
I prefer the encode/decode pattern but it doesn't really matter.
Suggested change
| (set-output utils n (json/generate-string v {:pretty false}))) | |
| (set-output utils n (json/encode v))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related zero88/gh-project-context#45
Related https://github.com/advthreat/iroh/pull/7176
Related https://github.com/advthreat/iroh/issues/7218
set-output is deprecated: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
The gh-project-context Action is upgraded to avoid the deprecated Node 12: zero88/gh-project-context#45
§ QA
No QA is needed.
§ Release Notes
§ Squashed Commits