credentials: Refactor GetCredentials and CheckCredentials

[romanornr]

This pull request introduces several important changes to the exchanges/credentials.go file, focusing on improving error handling and credential management. The most significant changes include modifying the CheckCredentials function to handle different authentication support scenarios, enhancing error messages in GetCredentials, and adding a fallback mechanism for default credentials.

Error Handling Improvements:

• func (b *Base) GetCredentials(ctx context.Context) (*account.Credentials, error): Enhanced the error message for context credentials store type assertion failures to provide more detailed information.

Credential Management Enhancements:

• func (b *Base) CheckCredentials(creds *account.Credentials, isContext bool) error: Reorganized the logic

• func (b *Base) GetCredentials(ctx context.Context) (*account.Credentials, error): small readability change

^^^ I mean, if copilot says so
Test do pass

also

if SubAccountOverride, ok := ctx.Value(account.ContextSubAccountFlag).(string); ok {
		b.API.credMu.RLock()
		creds.SubAccount = SubAccountOverride
		b.API.credMu.RUnlock()
	}

Is that lock required?

EDIT: I was experimenting around to understand the code base.

Will have to edit the commit, it wasn't supposed to return nil. Not sure, maybe IDE did it automatically since I did saw the comment

My main question was also about the lock being required. (Don't think it will lead to a noticeable performance gain when removed but can)

Type of change

Please delete options that are not relevant and add an x in [] as item is complete.

• Unnecessary improvement attempt

How has this been tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.

• go test ./... -race
• golangci-lint run
• Test X

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• [x ] I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
• [ x] My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally and on Github Actions with my changes
• Any dependent changes have been merged and published in downstream modules

[shazbert]

Thanks for the PR.

From initial look maybe I am missing something and need many more coffees but this doesn't seem to expand functionality. Could please add a proof (test) to show the expanded functionality.

You brought up the lock and you are correct that doesn't look like its needed at all and can be removed.

Also want to mention return nil instead of &account.Credentials{} is more appropriate on error but a few instances need to change across the wrapper implementations.

[shazbert]

revert; as its the same thing. You also purged a line of commentary.

[shazbert]

Returning nil causes panics in the CI builds, can you please rectify them. Can also change the error wrapping to fmt.Errorf("%w: %w", common.GetTypeAssertError(params...),errContextCredentialsFailure)

[romanornr]

Oh, crap I wasn't supposed to return nil (since the comment mentioned that)

*** I should remove tabnine from my IDE

[shazbert]

Can leave it as nil but you will need to do a bit more work. What you have done is more correct on what should happen. I will leave it up to you on what you want to do.

[shazbert]

Suggested change

	if SubAccountOverride, ok := ctx.Value(account.ContextSubAccountFlag).(string); ok {
	b.API.credMu.RLock()
	creds.SubAccount = SubAccountOverride
	b.API.credMu.RUnlock()
	}
	if subAccountOverride, ok := ctx.Value(account.ContextSubAccountFlag).(string); ok {
	b.API.credMu.RLock()
	creds.SubAccount = subAccountOverride
	b.API.credMu.RUnlock()
	}