Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK support to disable and hide context menu actions #83

Merged
merged 6 commits into from
Jan 26, 2025

Conversation

harshmeetTS
Copy link
Collaborator

The reference for disabled actions is taken from visual-embedd-sdk and will be replicated for BYOC

Copy link

github-actions bot commented Oct 26, 2024

File Coverage
All files 89%
src/main/custom-chart-context.ts 88%
src/main/logger.ts 88%
src/main/post-message-event-bridge.ts 81%
src/react/use-custom-chart-context.tsx 86%
src/react/mocks/custom-chart-context-mock.ts 96%
src/utils/date-formatting.ts 82%
src/utils/formatting-util.ts 89%
src/utils/conditional-formatting/conditional-formatting.ts 92%
src/utils/globalize-Initializer/globalize-utils.ts 95%
src/utils/number-formatting/number-formatting-utils.ts 98%
src/utils/number-formatting/number-formatting.ts 90%

Minimum allowed coverage is 0%

Generated by 🐒 cobertura-action against 327f231

@harshmeetTS harshmeetTS force-pushed the feat/visible-hidden-disabled-context-menu-actions branch from af7fd91 to 7acb658 Compare January 22, 2025 07:09
* Use this to specify which actions should be shown in the UI. Define either this or Hidden
* Actions
*/
customChartVisibleActions?: Action[];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we defined both arrays customChartHiddenActions and customChartVisibleActions then which one will be prioritise ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always visible will be higher priority

@harshmeetTS harshmeetTS force-pushed the feat/visible-hidden-disabled-context-menu-actions branch from c51dbb3 to 40df02c Compare January 22, 2025 15:24
@harshmeetTS harshmeetTS merged commit e81a470 into main Jan 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants