Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Example Charts with Tooltip #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

divyamlamiyan
Copy link
Contributor

No description provided.

@github-actions
Copy link

File Coverage
All files 86%
src/index.ts 0%
src/main/custom-chart-context.ts 87%
src/main/post-message-event-bridge.ts 96%
src/react/use-custom-chart-context.tsx 83%
src/react/mocks/custom-chart-context-mock.ts 76%

Minimum allowed coverage is 0%

Generated by 🐒 cobertura-action against 5c06f09

Comment on lines +193 to +195
tooltip: {
enabled: false,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be enabled right? we are not using native tooltips

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats why kept enabled to false

},
// onMouseOut: () => ctx.emitEvent(ChartToTSEvent.HideToolTip),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no chart level code change for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants