Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created redshift syncer #121

Merged
merged 3 commits into from
Apr 10, 2024
Merged

created redshift syncer #121

merged 3 commits into from
Apr 10, 2024

Conversation

saurabhsingh1608
Copy link
Contributor

Created new redshift syncer from scratch and used redshift-connector and sqlalchemy to connect to redshift. To use this connector we need to make VPC public

@boonhapus
Copy link
Collaborator

@saurabhsingh1608 are you able to share Redshift documentation links or process for making VPC public?

I'd like to include any setup steps in a section at the top like we have for Google based syncers

@boonhapus
Copy link
Collaborator

Can you also link me to Table.merge documentation for UPSERT capability? This would be a great capability, but I want to review it.

@boonhapus
Copy link
Collaborator

Is there a default port? Usually one of 8080 , 8989 , or 443 .

@boonhapus boonhapus changed the base branch from master to 152-syncers April 9, 2024 02:53
@boonhapus boonhapus self-requested a review April 9, 2024 02:54
@saurabhsingh1608
Copy link
Contributor Author

  1. For making VPC public ( we can add GIF also ) -> https://repost.aws/knowledge-center/redshift-cluster-private-public.
  2. For merge command ( i need to test it more because there is one more command we can use ) -> https://docs.aws.amazon.com/redshift/latest/dg/r_MERGE.html
  3. Default port is 5439 -> https://docs.aws.amazon.com/redshift/latest/mgmt/serverless-connecting.html

@boonhapus
Copy link
Collaborator

This is great @saurabhsingh1608 , thanks! For 2/ I will replace it with the generic upsert while we investigate MERGE INTO in the underlying driver. This can be a good performance improvement as we've seen in Snowflake's case.

@boonhapus boonhapus merged commit bdb4094 into thoughtspot:152-syncers Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants