Allow specific factories to skip primary key definition checks #444
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is only a proof of concept idea due to monkey-patching
FactoryBot::Factory
.Problem
A new default in factory_bot_rails is to raise errors when a factory is defining a primary key. There are occasionally needs to assign a
ActiveRecord
model's primary key explicitly in a factory (see examples in #438). We don't want to entirely skip that additional check for every factory by disablingreject_primary_key_attributes
for all factories.Possible Solution
Add a per factory configuration to skip the check for specific factories.