Redirect ember build errors to error file
#245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -282,7 +282,11 @@ def command(watch: false) | |||
| end | |||
| end | |||
|
|
|||
| "#{ember_path} build #{watch_flag} --environment #{environment} --output-path #{dist_path} #{log_pipe}" | |||
| "#{ember_path} build #{watch_flag} --environment #{environment} --output-path #{dist_path} #{redirect_errors} #{log_pipe}" | |||
Initial steps toward closing [#240]. Pipe `ember build` errors from `$STDERR` to `ember-cli-rails`'s build error file. Depends on [ember-cli/ember-cli#5038] [#240]: #240 [ember-cli/ember-cli#5038]: ember-cli/ember-cli#5038
seanpdoyle
force-pushed
the
sd-pipe-stderr-to-error-file
branch
from
b27cd22
to
3703693
Compare
seanpdoyle
added a commit
that referenced
this pull request
Nov 12, 2015
The future use cases of this project expect that the build will complete before serving the Ember applications. Additionally, build timeouts used to act as a workaround for when the EmberCLI build had errors that weren't being communicated to the Rails process. Now that [EmberCLI writes errors to STDERR][stderr], which EmberCLI-Rails [pipes STDERR to a file][pipe] for monitoring, EmberCLI build errors will be raised by the Rails process. For Users who care about timeouts, [rack-timeout] serves as a great alternative. [stderr]: ember-cli/ember-cli#5039 [pipe]: #245 [rack-timeout]: https://github.com/heroku/rack-timeout
seanpdoyle
added a commit
that referenced
this pull request
Nov 12, 2015
The future use cases of this project expect that the build will complete before serving the Ember applications. Additionally, build timeouts used to act as a workaround for when the EmberCLI build had errors that weren't being communicated to the Rails process. Now that [EmberCLI writes errors to STDERR][stderr], which EmberCLI-Rails [pipes STDERR to a file][pipe] for monitoring, EmberCLI build errors will be raised by the Rails process. For Users who care about timeouts, [rack-timeout] serves as a great alternative. [stderr]: ember-cli/ember-cli#5039 [pipe]: #245 [rack-timeout]: https://github.com/heroku/rack-timeout
seanpdoyle
added a commit
that referenced
this pull request
Nov 14, 2015
Closes [#262]. Managing user dependencies within app code is more trouble than it's worth. Being explicit about our EmberCLI support in our `README.md` and keeping the addon version in lock-step with the gem will be a better solution long term. Since EmberCLI now [writes to STDERR][stderr], which EmberCLI-Rails [pipes to a file and monitors][error-file], front-end failures will communicated to users through normal Error-raising means. [#262]: #262 [stderr]: ember-cli/ember-cli#5039 [error-file]: #245
seanpdoyle
added a commit
that referenced
this pull request
Nov 14, 2015
Closes [#262]. Managing user dependencies within app code is more trouble than it's worth. Being explicit about our EmberCLI support in our `README.md` and keeping the addon version in lock-step with the gem will be a better solution long term. Since EmberCLI now [writes to STDERR][stderr], which EmberCLI-Rails [pipes to a file and monitors][error-file], front-end failures will communicated to users through normal Error-raising means. [#262]: #262 [stderr]: ember-cli/ember-cli#5039 [error-file]: #245
seanpdoyle
added a commit
that referenced
this pull request
Nov 14, 2015
Closes [#262]. Managing user dependencies within app code is more trouble than it's worth. Being explicit about our EmberCLI support in our `README.md` and keeping the addon version in lock-step with the gem will be a better solution long term. Since EmberCLI now [writes to STDERR][stderr], which EmberCLI-Rails [pipes to a file and monitors][error-file], front-end failures will communicated to users through normal Error-raising means. [#262]: #262 [stderr]: ember-cli/ember-cli#5039 [error-file]: #245
seanpdoyle
added a commit
that referenced
this pull request
Nov 14, 2015
Closes [#262]. Managing user dependencies within app code is more trouble than it's worth. Being explicit about our EmberCLI support in our `README.md` and keeping the addon version in lock-step with the gem will be a better solution long term. Since EmberCLI now [writes to STDERR][stderr], which EmberCLI-Rails [pipes to a file and monitors][error-file], front-end failures will communicated to users through normal Error-raising means. [#262]: #262 [stderr]: ember-cli/ember-cli#5039 [error-file]: #245
seanpdoyle
added a commit
that referenced
this pull request
Nov 14, 2015
Closes [#262]. Managing user dependencies within app code is more trouble than it's worth. Being explicit about our EmberCLI support in our `README.md` and keeping the addon version in lock-step with the gem will be a better solution long term. Since EmberCLI now [writes to STDERR][stderr], which EmberCLI-Rails [pipes to a file and monitors][error-file], front-end failures will communicated to users through normal Error-raising means. [#262]: #262 [stderr]: ember-cli/ember-cli#5039 [error-file]: #245
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial steps toward closing #240.
Pipe
ember builderrors from$STDERRtoember-cli-rails's builderror file.
Depends on ember-cli/ember-cli#5038