Allow passing through of the full-index option. #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has inadvertently made me aware of a syntax issue meaning that the tests aren't running properly. Locally, the following line passes: expect(output).to include
'bundle install --gemfile=gemfiles/1.0.0.gemfile --jobs=2'But this doesn't: expect(output).to include(
'bundle install --gemfile=gemfiles/1.0.0.gemfile --jobs=2'
) |
mike-burns
reviewed
Feb 23, 2018
spec/acceptance/cli/install_spec.rb
Outdated
| @@ -67,4 +68,23 @@ | |||
| 'bundle install --gemfile=gemfiles/1.0.0.gemfile --jobs=1') | |||
| end | |||
| end | |||
|
|
|||
| context "with full-index", parallel: true do | |||
There was a problem hiding this comment.
A synonym for parallel: true is :parallel.
There was a problem hiding this comment.
Oh, nice, thanks! I hadn't thought of that.
nickcharlton
force-pushed
the
nc-full-index
branch
from
1d9a9a8 to
287a196
Compare
nickcharlton
force-pushed
the
nc-full-index
branch
from
287a196 to
d942b67
Compare
Bundler provides an option to fetch the full RubyGems index. This is useful in the case of really old dependencies (like Rails 3 in 2018) which still work, but are not returned normally. This allows passing that through to `bundle install`.
nickcharlton
force-pushed
the
nc-full-index
branch
from
3c89ca4 to
5445dee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundler provides an option to fetch the full RubyGems index. This is
useful in the case of really old dependencies (like Rails 3 in 2018)
which still work, but are not returned normally. This allows passing
that through to
bundle install.