-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md to add appraisal in gemspec instead of Gemfile #122
Conversation
It might be worthwhile to call out why this goes in the gemspec instead of the Gemfile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aripollak one small request to update the quotes please.
Alternatively you can allow commits from maintainers on your PR and I can make this adjustment.
README.md
Outdated
|
||
gem "appraisal" | ||
s.add_development_dependency 'appraisal' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please could this be changed to double quotes, so it remains consistent with the rest of the readme?
@odlp done. Looks like the allow-edits box is already checked too. |
Why this? I actually prefer the other way around, since for example I'm able to point directly to the master branch in github if I need to. |
@deivid-rodriguez on a new gem project, putting appraisal in Gemfile wasn't working. |
mmmm, can you be more specific? What wasn't working? I did a simple test and it worked fine: deivid@pantani ~/Code $ bundle gem testgem
Creating gem 'testgem'...
MIT License enabled in config
Code of conduct enabled in config
create testgem/Gemfile
create testgem/.gitignore
create testgem/lib/testgem.rb
create testgem/lib/testgem/version.rb
create testgem/testgem.gemspec
create testgem/Rakefile
create testgem/README.md
create testgem/bin/console
create testgem/bin/setup
create testgem/.travis.yml
create testgem/.rspec
create testgem/spec/spec_helper.rb
create testgem/spec/testgem_spec.rb
create testgem/LICENSE.txt
create testgem/CODE_OF_CONDUCT.md
Initializing git repo in /home/deivid/Code/testgem
deivid@pantani ~/Code $ cd testgem/
deivid@pantani ~/Code/testgem $ sed -i 's/TODO/something/' testgem.gemspec
deivid@pantani ~/Code/testgem $ echo "gem 'appraisal'" >> Gemfile
deivid@pantani ~/Code/testgem $ bundle
Fetching gem metadata from https://rubygems.org/.........
Fetching version metadata from https://rubygems.org/.
Resolving dependencies...
Using rake 10.5.0
Using bundler 1.14.6
Using thor 0.19.4
Using diff-lcs 1.3
Using rspec-support 3.5.0
Using testgem 0.1.0 from source at `.`
Using appraisal 2.2.0
Using rspec-core 3.5.4
Using rspec-expectations 3.5.0
Using rspec-mocks 3.5.0
Using rspec 3.5.0
Bundle complete! 5 Gemfile dependencies, 11 gems now installed.
Use `bundle show [gemname]` to see where a bundled gem is installed.
deivid@pantani ~/Code/testgem $ |
@deivid-rodriguez when using |
Yes, I've heard that argument before: "I do it because My personal best practice is to specify |
I'm not really sure if this is the right thing to do, so this is more of an RFC. I was just trying to set up appraisal in a gem that was created a year ago and the instructions weren't working.