Enable Embroider #1
Conversation
|
|
||
| #### Fingerprinting | ||
|
|
||
| In classic builds there was a `app.options.fingerprint.exclude` configuration which users could configure to disable fingerprinting for specific files or `app.options.fingerprint.enabled` field to disable fingerprinting for all files. Under Embroider, JS and CSS assets will always be fingerprinted in production mode (all app code is always fingerprinted even in dev mode as they will become "chunks") except for any asset that contains the data attribute `data-embroider-ignore`. An example of this is that `testem.js` is [excluded from fingerprinting](https://github.com/ember-cli/ember-cli/blob/1301d24c8d7dec1f1559cffd0688d46bcd50284e/lib/broccoli/ember-app.js#L351-L355) as that explicit file name is expected. However, under embroider we can change `tests/index.html` to contain: |
There was a problem hiding this comment.
Are other fingerprint options still supported?
There was a problem hiding this comment.
Currently no. I can make this section state more explicitly that app.options.fingerprint are not enabled
There was a problem hiding this comment.
I think we could (should?) point out that there is still quite a gap in the functionality, as Embroider will only fingerprint the basic JS and CSS files that it adds to index.html. broccoli-asset-rev would fingerprint arbitrary files, e.g. images, and rewrite all the references to those (as long as it can "see" the file paths, so they have to be literals, i.e. no dynamic concatenations logic or so), e.g in JS or CSS files. AFAIK there is no solution for this yet in Embroider-land.
Which is quite annoying as you cannot serve images with HTTP headers that enable long-term browser caching as you normally would. Or if you do, they are not invalidated when they change.
And people are probably quite used to this (the previous behavior), so when this does not work it would feel like a bug rather than a missing feature.
Co-authored-by: Katie Gengler <[email protected]>
Co-authored-by: Katie Gengler <[email protected]>
Co-authored-by: Katie Gengler <[email protected]>
Co-authored-by: Katie Gengler <[email protected]>
Co-authored-by: David Baker <[email protected]>
Co-authored-by: David Baker <[email protected]>
Co-authored-by: David Baker <[email protected]>
Co-authored-by: David Baker <[email protected]>
Co-authored-by: David Baker <[email protected]>
Co-authored-by: David Baker <[email protected]>
Co-authored-by: David Baker <[email protected]>
|
I am going to squash down these commits and open this in the upstream RFC repo. I will copy over the open comment so we don't lose it. |
Rendered