[CLEANUP] Moving off QUnit.config.current.assert

Moving off of the QUnit global by refactoring away from QUnit.config.current.assert. Apart of emberjs#15988
thoov · Apr 3, 2018 · 9af8bc4 · 9af8bc4
1 parent 0ec7f45
commit 9af8bc4
Show file tree

Hide file tree

Showing 33 changed files with 67 additions and 61 deletions.
diff --git a/packages/ember-application/tests/system/application_test.js b/packages/ember-application/tests/system/application_test.js
@@ -212,7 +212,7 @@ moduleFor(
   'Application, default resolver with autoboot',
   class extends DefaultResolverApplicationTestCase {
     constructor() {
-      super();
+      super(...arguments);
       this.originalLookup = context.lookup;
     }
 
@@ -263,7 +263,7 @@ moduleFor(
   'Application, autobooting',
   class extends AutobootApplicationTestCase {
     constructor() {
-      super();
+      super(...arguments);
       this.originalLogVersion = ENV.LOG_VERSION;
       this.originalDebug = getDebugFunction('debug');
       this.originalWarn = getDebugFunction('warn');

diff --git a/packages/ember-glimmer/tests/integration/application/actions-test.js b/packages/ember-glimmer/tests/integration/application/actions-test.js
@@ -11,7 +11,7 @@ moduleFor(
   class extends ApplicationTest {
     constructor() {
       setDebugFunction('debug', noop);
-      super();
+      super(...arguments);
     }
 
     teardown() {

diff --git a/packages/ember-glimmer/tests/integration/application/rendering-test.js b/packages/ember-glimmer/tests/integration/application/rendering-test.js
@@ -9,7 +9,7 @@ moduleFor(
   'Application test: rendering',
   class extends ApplicationTest {
     constructor() {
-      super();
+      super(...arguments);
       this._APPLICATION_TEMPLATE_WRAPPER = ENV._APPLICATION_TEMPLATE_WRAPPER;
     }
 

diff --git a/packages/ember-glimmer/tests/integration/components/append-test.js b/packages/ember-glimmer/tests/integration/components/append-test.js
@@ -5,7 +5,7 @@ import { strip } from '../../utils/abstract-test-case';
 
 class AbstractAppendTest extends RenderingTest {
   constructor() {
-    super();
+    super(...arguments);
 
     this.components = [];
     this.ids = [];

diff --git a/packages/ember-glimmer/tests/integration/components/curly-components-test.js b/packages/ember-glimmer/tests/integration/components/curly-components-test.js
@@ -13,7 +13,7 @@ moduleFor(
   'Components test: curly components',
   class extends RenderingTest {
     constructor() {
-      super();
+      super(...arguments);
       this.originalDidInitAttrsSupport = ENV._ENABLE_DID_INIT_ATTRS_SUPPORT;
     }
 

diff --git a/packages/ember-glimmer/tests/integration/components/instrumentation-compile-test.js b/packages/ember-glimmer/tests/integration/components/instrumentation-compile-test.js
@@ -6,7 +6,7 @@ moduleFor(
   'Components compile instrumentation',
   class extends RenderingTest {
     constructor() {
-      super();
+      super(...arguments);
 
       this.resetEvents();
 

diff --git a/packages/ember-glimmer/tests/integration/components/instrumentation-test.js b/packages/ember-glimmer/tests/integration/components/instrumentation-test.js
@@ -6,7 +6,7 @@ moduleFor(
   'Components instrumentation',
   class extends RenderingTest {
     constructor() {
-      super();
+      super(...arguments);
 
       this.resetEvents();
 

diff --git a/packages/ember-glimmer/tests/integration/components/life-cycle-test.js b/packages/ember-glimmer/tests/integration/components/life-cycle-test.js
@@ -10,7 +10,7 @@ import { runAppend } from 'internal-test-helpers';
 
 class LifeCycleHooksTest extends RenderingTest {
   constructor() {
-    super();
+    super(...arguments);
     this.hooks = [];
     this.components = {};
     this.componentRegistry = [];

diff --git a/packages/ember-glimmer/tests/integration/components/target-action-test.js b/packages/ember-glimmer/tests/integration/components/target-action-test.js
@@ -10,7 +10,7 @@ moduleFor(
   'Components test: sendAction',
   class extends RenderingTest {
     constructor() {
-      super();
+      super(...arguments);
       this.actionCounts = {};
       this.sendCount = 0;
       this.actionArguments = null;

diff --git a/packages/ember-glimmer/tests/integration/components/template-only-components-test.js b/packages/ember-glimmer/tests/integration/components/template-only-components-test.js
@@ -12,7 +12,7 @@ moduleFor(
   'Components test: template-only components (glimmer components)',
   class extends TemplateOnlyComponentsTest {
     constructor() {
-      super();
+      super(...arguments);
       this._TEMPLATE_ONLY_GLIMMER_COMPONENTS = ENV._TEMPLATE_ONLY_GLIMMER_COMPONENTS;
       ENV._TEMPLATE_ONLY_GLIMMER_COMPONENTS = true;
     }
@@ -112,7 +112,7 @@ moduleFor(
   'Components test: template-only components (curly components)',
   class extends TemplateOnlyComponentsTest {
     constructor() {
-      super();
+      super(...arguments);
       this._TEMPLATE_ONLY_GLIMMER_COMPONENTS = ENV._TEMPLATE_ONLY_GLIMMER_COMPONENTS;
       ENV._TEMPLATE_ONLY_GLIMMER_COMPONENTS = false;
     }

diff --git a/packages/ember-glimmer/tests/integration/components/utils-test.js b/packages/ember-glimmer/tests/integration/components/utils-test.js
@@ -13,7 +13,7 @@ moduleFor(
   'View tree tests',
   class extends ApplicationTest {
     constructor() {
-      super();
+      super(...arguments);
 
       this.addComponent('x-tagless', {
         ComponentClass: Component.extend({

diff --git a/packages/ember-glimmer/tests/integration/event-dispatcher-test.js b/packages/ember-glimmer/tests/integration/event-dispatcher-test.js
@@ -113,7 +113,7 @@ moduleFor(
   'EventDispatcher#setup',
   class extends RenderingTest {
     constructor() {
-      super();
+      super(...arguments);
 
       let dispatcher = this.owner.lookup('event_dispatcher:main');
       run(dispatcher, 'destroy');

diff --git a/packages/ember-glimmer/tests/integration/helpers/custom-helper-test.js b/packages/ember-glimmer/tests/integration/helpers/custom-helper-test.js
@@ -3,8 +3,6 @@ import { RenderingTest, moduleFor } from '../../utils/test-case';
 import { runDestroy } from 'internal-test-helpers';
 import { set } from 'ember-metal';
 
-let assert = QUnit.assert;
-
 moduleFor(
   'Helpers test: custom helpers',
   class extends RenderingTest {
@@ -88,7 +86,7 @@ moduleFor(
       }, /You must call `this._super\(...arguments\);` when overriding `init` on a framework object. Please update .* to call `this._super\(...arguments\);` from `init`./);
     }
 
-    ['@test class-based helper can recompute a new value']() {
+    ['@test class-based helper can recompute a new value'](assert) {
       let destroyCount = 0;
       let computeCount = 0;
       let helper;
@@ -122,7 +120,7 @@ moduleFor(
       assert.strictEqual(destroyCount, 0, 'destroy is not called on recomputation');
     }
 
-    ['@test class-based helper with static arguments can recompute a new value']() {
+    ['@test class-based helper with static arguments can recompute a new value'](assert) {
       let destroyCount = 0;
       let computeCount = 0;
       let helper;
@@ -180,7 +178,7 @@ moduleFor(
       this.assertText('bob');
     }
 
-    ['@test simple helper is called for param changes']() {
+    ['@test simple helper is called for param changes'](assert) {
       let computeCount = 0;
 
       this.registerHelper('hello-world', ([value]) => {
@@ -215,7 +213,7 @@ moduleFor(
       assert.strictEqual(computeCount, 3, 'compute is called exactly 3 times');
     }
 
-    ['@test class-based helper compute is called for param changes']() {
+    ['@test class-based helper compute is called for param changes'](assert) {
       let createCount = 0;
       let computeCount = 0;
 
@@ -417,7 +415,7 @@ moduleFor(
       }, /Compile Error some-helper is not a modifier: Helpers may not be used in the element form/);
     }
 
-    ['@test class-based helper is torn down']() {
+    ['@test class-based helper is torn down'](assert) {
       let destroyCalled = 0;
 
       this.registerHelper('some-helper', {
@@ -585,7 +583,9 @@ moduleFor(
       assert.equal(instance.compute(), 'lolol', 'can invoke `.compute`');
     }
 
-    ['@test class-based helper can be invoked manually via `owner.factoryFor(...).create().compute()']() {
+    ['@test class-based helper can be invoked manually via `owner.factoryFor(...).create().compute()'](
+      assert
+    ) {
       this.registerHelper('some-helper', {
         compute() {
           assert.ok(true, 'some-helper helper invoked');
@@ -646,7 +646,7 @@ if (!EmberDev.runningProdBuild) {
     'Helpers test: mutation triggers errors - class based helper',
     class extends HelperMutatingArgsTests {
       constructor() {
-        super();
+        super(...arguments);
 
         let compute = this.buildCompute();
 
@@ -661,7 +661,7 @@ if (!EmberDev.runningProdBuild) {
     'Helpers test: mutation triggers errors - simple helper',
     class extends HelperMutatingArgsTests {
       constructor() {
-        super();
+        super(...arguments);
 
         let compute = this.buildCompute();
 

diff --git a/packages/ember-glimmer/tests/integration/helpers/loc-test.js b/packages/ember-glimmer/tests/integration/helpers/loc-test.js
@@ -6,7 +6,7 @@ moduleFor(
   'Helpers test: {{loc}}',
   class extends RenderingTest {
     constructor() {
-      super();
+      super(...arguments);
       setStrings({
         'Hello Friend': 'Hallo Freund',
         Hello: 'Hallo, %@',

diff --git a/packages/ember-glimmer/tests/integration/helpers/log-test.js b/packages/ember-glimmer/tests/integration/helpers/log-test.js
@@ -4,7 +4,7 @@ moduleFor(
   'Helpers test: {{log}}',
   class extends RenderingTest {
     constructor() {
-      super();
+      super(...arguments);
       /* eslint-disable no-console */
       this.originalLog = console.log;
       this.logCalls = [];

diff --git a/packages/ember-glimmer/tests/integration/helpers/render-test.js b/packages/ember-glimmer/tests/integration/helpers/render-test.js
@@ -7,7 +7,7 @@ moduleFor(
   'Helpers test: {{render}}',
   class extends RenderingTest {
     constructor() {
-      super();
+      super(...arguments);
       this.originalRenderSupport = ENV._ENABLE_RENDER_SUPPORT;
       ENV._ENABLE_RENDER_SUPPORT = true;
     }

diff --git a/packages/ember-glimmer/tests/integration/mount-test.js b/packages/ember-glimmer/tests/integration/mount-test.js
@@ -51,7 +51,7 @@ moduleFor(
   '{{mount}} test',
   class extends ApplicationTest {
     constructor() {
-      super();
+      super(...arguments);
 
       let engineRegistrations = (this.engineRegistrations = {});
 
@@ -302,7 +302,7 @@ if (EMBER_ENGINES_MOUNT_PARAMS) {
     '{{mount}} params tests',
     class extends ApplicationTest {
       constructor() {
-        super();
+        super(...arguments);
 
         this.add(
           'engine:paramEngine',

diff --git a/packages/ember-glimmer/tests/integration/syntax/each-in-test.js b/packages/ember-glimmer/tests/integration/syntax/each-in-test.js
@@ -287,7 +287,7 @@ moduleFor(
   'Syntax test: {{#each-in}} with POJOs',
   class extends EachInTest {
     constructor() {
-      super();
+      super(...arguments);
       this.allowsSetProp = true;
     }
 
@@ -460,7 +460,7 @@ moduleFor(
   'Syntax test: {{#each-in}} with EmberObjects',
   class extends EachInTest {
     constructor() {
-      super();
+      super(...arguments);
       this.allowsSetProp = true;
     }
     createHash(pojo) {
@@ -485,7 +485,7 @@ moduleFor(
   'Syntax test: {{#each-in}} with object proxies',
   class extends EachInTest {
     constructor() {
-      super();
+      super(...arguments);
       this.allowsSetProp = true;
     }
     createHash(pojo) {

diff --git a/packages/ember-glimmer/tests/integration/syntax/each-test.js b/packages/ember-glimmer/tests/integration/syntax/each-test.js
@@ -1128,7 +1128,7 @@ if (typeof MutationObserver === 'function') {
     'Syntax test: {{#each as}} DOM mutation test',
     class extends RenderingTest {
       constructor() {
-        super();
+        super(...arguments);
         this.observer = null;
       }
 

diff --git a/packages/ember-glimmer/tests/integration/syntax/experimental-syntax-test.js b/packages/ember-glimmer/tests/integration/syntax/experimental-syntax-test.js
@@ -15,7 +15,7 @@ moduleFor(
         });
       });
 
-      super();
+      super(...arguments);
       this.originalMacros = originalMacros;
     }