Allow to be run without middleware + improve request reading consistency #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an excellent change. I was intending to submit a PR to improve the docs with an explanation of this quirk because it tripped me up for about 30 minutes until I found this: However, removing this requirement is awesome. Thank you! |
|
Will be testing this in our clusters shortly |
|
Tested in live environment, all good 👍 |
|
Docs+examples need to be updated as part of this change |
Prior to this change, the request URI was only ever read from the X-Forwarded-Uri header which was only set when the container was accessed via the forwardauth middleware. As such, it was necessary to apply the treafik-forward-auth middleware to the treafik-forward-auth container when running auth host mode. This is a quirk, unecessary complexity and is a frequent source of configuration issues.
thomseddon
force-pushed
the
fix/dont-require-self-middleware
branch
from
8c57d17 to
acca1b8
Compare
|
Docs and examples updated |
|
👍 this made my head spin today as I was learning to use this app with an auth host - this patch or applying the middleware on the auth host sorted it out for me. Thanks! |
mkska
pushed a commit
to mkska/traefik-forward-auth
that referenced
this pull request
Aug 22, 2023
…ncy (thomseddon#217) Prior to this change, the request URI was only ever read from the X-Forwarded-Uri header which was only set when the container was accessed via the forwardauth middleware. As such, it was necessary to apply the treafik-forward-auth middleware to the treafik-forward-auth container when running auth host mode. This is a quirk, unnecessary complexity and is a frequent source of configuration issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the request URI was only ever read from the X-Forwarded-Uri header which was only set when the container was accessed via the forwardauth middleware. As such, it was necessary to apply the treafik-forward-auth middleware to the treafik-forward-auth container when running auth host mode.
This is a quirk, unnecessary complexity and is a frequent source of configuration issues.