Skip to content

Inverted the mocking approach #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thompsongl merged 1 commit into from
Feb 25, 2020
Merged

Inverted the mocking approach #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/jest/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@
],
"moduleNameMapper": {
"\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$": "<rootDir>/scripts/jest/mocks/file_mock.js",
"\\.(css|less|scss)$": "<rootDir>/scripts/jest/mocks/style_mock.js"
"\\.(css|less|scss)$": "<rootDir>/scripts/jest/mocks/style_mock.js",
"/icon$": "<rootDir>/scripts/jest/mocks/icon_mock.js"
},
"setupFiles": [
"<rootDir>/scripts/jest/setup/polyfills.js",
"<rootDir>/scripts/jest/setup/enzyme.js",
"<rootDir>/scripts/jest/setup/throw_on_console_error.js"
],
"setupFilesAfterEnv": ["<rootDir>/scripts/jest/setup/mocks.js"],
"coverageDirectory": "<rootDir>/reports/jest-coverage",
"coverageReporters": [
"html"
Expand Down
1 change: 1 addition & 0 deletions scripts/jest/mocks/icon_mock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from '../../../src/components/icon/icon.testenv';
6 changes: 0 additions & 6 deletions scripts/jest/setup/mocks.js
View file
Open in desktop

This file was deleted.

24 changes: 6 additions & 18 deletions src/components/empty_prompt/__snapshots__/empty_prompt.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,9 @@ exports[`EuiEmptyPrompt is rendered 1`] = `
class="euiEmptyPrompt testClass1 testClass2"
data-test-subj="test subject string"
>
<svg
aria-hidden="true"
class="euiIcon euiIcon--xxLarge euiIcon--subdued euiIcon-isLoading"
focusable="false"
height="16"
role="img"
viewBox="0 0 16 16"
width="16"
xmlns="http://www.w3.org/2000/svg"
<div
color="subdued"
data-euiicon-type="arrowUp"
/>
<div
class="euiSpacer euiSpacer--s"
Expand Down Expand Up @@ -105,15 +99,9 @@ exports[`EuiEmptyPrompt props iconType renders alone 1`] = `
<div
class="euiEmptyPrompt"
>
<svg
aria-hidden="true"
class="euiIcon euiIcon--xxLarge euiIcon--subdued euiIcon-isLoading"
focusable="false"
height="16"
role="img"
viewBox="0 0 16 16"
width="16"
xmlns="http://www.w3.org/2000/svg"
<div
color="subdued"
data-euiicon-type="arrowUp"
/>
<div
class="euiSpacer euiSpacer--s"
Expand Down
4 changes: 4 additions & 0 deletions src/components/icon/icon.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ import cheerio from 'cheerio';
import { EuiIcon, SIZES, TYPES, COLORS } from './icon';
import { PropsOf } from '../common';

jest.mock('./icon', () => {
return require.requireActual('./icon');
});

const prettyHtml = cheerio.load('');

function testIcon(props: PropsOf<EuiIcon>) {
Expand Down