Repository navigation
feat(engine): raise thread pool minimum when blocking tests starve the pool #7030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8f8da2a
feat(engine): raise thread pool minimum when blocking tests starve th…
thomhurst 127165e
feat(settings): add Execution.ThreadPoolTuningEnabled
thomhurst d175009
fix(engine): harden thread pool starvation monitor per review
thomhurst 2b5515b
fix(engine): make starvation detection jitter-tolerant and avoid per-…
thomhurst e97f2e3
fix(engine): clamp starvation monitor cap and log raises
thomhurst 83b29ea
fix(engine): escalate starvation raise and detect saturation by busy …
thomhurst 476c856
fix(engine): clamp starvation monitor raise to the pool maximum
thomhurst 162ea8c
chore(engine): document starvation monitor assumptions and log why it…
thomhurst 9a54757
fix(engine): keep starvation monitoring when the minimum already meet…
thomhurst 3eb4412
test(engine): keep escalation tests valid on runners with 3 or fewer …
thomhurst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| namespace TUnit.Engine.Configuration; | ||
|
|
||
| internal static class EnvironmentFlags | ||
| { | ||
| /// <summary> | ||
| /// The truthy vocabulary shared by the TUNIT_DISABLE_* switches: <c>1</c>, <c>true</c> or <c>yes</c>. | ||
| /// </summary> | ||
| public static bool IsTruthy(string? value) | ||
| => value is not null && | ||
| (value.Equals("true", StringComparison.OrdinalIgnoreCase) || | ||
| value.Equals("1", StringComparison.Ordinal) || | ||
| value.Equals("yes", StringComparison.OrdinalIgnoreCase)); | ||
|
|
||
| public static bool IsSet(string variableName) | ||
| => IsTruthy(Environment.GetEnvironmentVariable(variableName)); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.