Skip to content

fix(aspnetcore): initialize web application factories through services #6956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
Oct 3, 2026
Merged

fix(aspnetcore): initialize web application factories through services #6956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/TUnit.AspNetCore.Core/WebApplicationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ namespace TUnit.AspNetCore;
public abstract class WebApplicationTest
{
// Shared across all generic instantiations of WebApplicationTest<TFactory, TEntryPoint>.
// WebApplicationFactory.Server is synchronous; Task.Run prevents blocking async threads,
// WebApplicationFactory.Services is synchronous; Task.Run prevents blocking async threads,
// and this semaphore caps concurrent DI container builds to avoid thread pool starvation.
// Capped at 8: startup is reflection/I/O-bound, not CPU-bound, so ProcessorCount alone
// would allow too many concurrent builds on high-core-count machines.
Expand Down Expand Up @@ -127,12 +127,13 @@ public async Task InitializeFactoryAsync(TestContext testContext)
(_, config) => ConfigureTestConfiguration(config),
ConfigureWebHostBuilder));

// Semaphore guards only the Server property access (the synchronous host build),
// Services initializes both TestServer and Kestrel; Server only supports TestServer.
// Semaphore guards only the Services property access (the synchronous host build),
// not the factory creation above which is fast synchronous configuration.
await ServerInitSemaphore.WaitAsync(testContext.Execution.CancellationToken);
try
{
await Task.Run(() => _ = _factory.Server, testContext.Execution.CancellationToken);
await Task.Run(() => _ = _factory.Services, testContext.Execution.CancellationToken);
Comment thread
thomhurst marked this conversation as resolved.
}
finally
{
Expand Down
Loading