-
-
Notifications
You must be signed in to change notification settings - Fork 136
perf: skip unannotated property data-source candidates #6784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+91
−1
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 changes: 87 additions & 0 deletions
87
tests/TUnit.Core.SourceGenerator.Tests/PropertyInjectionIncrementalTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| using Microsoft.CodeAnalysis; | ||
| using Microsoft.CodeAnalysis.CSharp; | ||
| using TUnit.Core.SourceGenerator.Generators; | ||
|
|
||
| namespace TUnit.Core.SourceGenerator.Tests; | ||
|
|
||
| public class PropertyInjectionIncrementalTests | ||
| { | ||
| private const string Source = """ | ||
| using TUnit.Core; | ||
| public class Fixture { } | ||
| public class Tests | ||
| { | ||
| [ClassDataSource<Fixture>] | ||
| public Fixture Value { get; set; } | ||
| } | ||
| """; | ||
|
|
||
| [Test] | ||
| public async Task AddingAndRemovingReferenceRefreshesCompilationTypes() | ||
| { | ||
| var withoutCore = ReferencesHelper.References | ||
| .Where(reference => !string.Equals(Path.GetFileName(reference.FilePath), "TUnit.Core.dll", StringComparison.OrdinalIgnoreCase)) | ||
| .ToArray(); | ||
| var compilation = CreateCompilation().WithReferences(withoutCore); | ||
| GeneratorDriver driver = CSharpGeneratorDriver.Create(new PropertyInjectionSourceGenerator()); | ||
|
|
||
| driver = driver.RunGenerators(compilation); | ||
| await Assert.That(driver.GetRunResult().GeneratedTrees).IsEmpty(); | ||
|
|
||
| compilation = compilation.WithReferences(ReferencesHelper.References); | ||
| await Assert.That(compilation.GetDiagnostics().Where(d => d.Severity == DiagnosticSeverity.Error)).IsEmpty(); | ||
| driver = driver.RunGenerators(compilation); | ||
| await Assert.That(GetSource(driver)).Contains("PropertyName = \"Value\""); | ||
|
|
||
| driver = driver.RunGenerators(compilation.WithReferences(withoutCore)); | ||
| await Assert.That(driver.GetRunResult().GeneratedTrees).IsEmpty(); | ||
| await Assert.That(driver.GetRunResult().Diagnostics.Where(d => d.Severity == DiagnosticSeverity.Error)).IsEmpty(); | ||
| } | ||
|
|
||
| [Test] | ||
| public async Task PropertyEditUpdatesReusedDriver() | ||
| { | ||
| var compilation = CreateCompilation(); | ||
| GeneratorDriver driver = CSharpGeneratorDriver.Create(new PropertyInjectionSourceGenerator()); | ||
| driver = driver.RunGenerators(compilation); | ||
| await Assert.That(GetSource(driver)).Contains("PropertyName = \"Value\""); | ||
|
|
||
| var originalTree = compilation.SyntaxTrees.Single(); | ||
| compilation = compilation.ReplaceSyntaxTree(originalTree, | ||
| CSharpSyntaxTree.ParseText(Source.Replace("Value", "Renamed"))); | ||
| driver = driver.RunGenerators(compilation); | ||
|
|
||
| await Assert.That(GetSource(driver)).Contains("PropertyName = \"Renamed\""); | ||
| await Assert.That(GetSource(driver)).DoesNotContain("PropertyName = \"Value\""); | ||
| await Assert.That(driver.GetRunResult().Diagnostics.Where(d => d.Severity == DiagnosticSeverity.Error)).IsEmpty(); | ||
| } | ||
|
|
||
| private static string GetSource(GeneratorDriver driver) => | ||
| string.Join("\n", driver.GetRunResult().GeneratedTrees.Select(tree => tree.ToString())); | ||
|
|
||
| [Test] | ||
| public async Task AddingAndRemovingAttributeUpdatesReusedDriver() | ||
| { | ||
| var plainSource = Source.Replace("[ClassDataSource<Fixture>]", ""); | ||
| var compilation = CreateCompilation().RemoveAllSyntaxTrees().AddSyntaxTrees(CSharpSyntaxTree.ParseText(plainSource)); | ||
| GeneratorDriver driver = CSharpGeneratorDriver.Create(new PropertyInjectionSourceGenerator()); | ||
| driver = driver.RunGenerators(compilation); | ||
| await Assert.That(driver.GetRunResult().GeneratedTrees).IsEmpty(); | ||
|
|
||
| compilation = compilation.ReplaceSyntaxTree(compilation.SyntaxTrees.Single(), CSharpSyntaxTree.ParseText(Source)); | ||
| driver = driver.RunGenerators(compilation); | ||
| await Assert.That(GetSource(driver)).Contains("PropertyName = \"Value\""); | ||
|
|
||
| compilation = compilation.ReplaceSyntaxTree(compilation.SyntaxTrees.Single(), CSharpSyntaxTree.ParseText(plainSource)); | ||
| driver = driver.RunGenerators(compilation); | ||
| await Assert.That(driver.GetRunResult().GeneratedTrees).IsEmpty(); | ||
| await Assert.That(driver.GetRunResult().Diagnostics.Where(d => d.Severity == DiagnosticSeverity.Error)).IsEmpty(); | ||
| } | ||
|
|
||
| private static CSharpCompilation CreateCompilation() => CSharpCompilation.Create( | ||
| "PropertyInjectionEdits", | ||
| [CSharpSyntaxTree.ParseText(Source)], | ||
| ReferencesHelper.References, | ||
| new CSharpCompilationOptions(OutputKind.DynamicallyLinkedLibrary)); | ||
| } | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new predicate specifically keeps partial properties because their data-source attribute may be on the other declaration, but the added tests cover only a non-partial property with a directly attached attribute. Add a test that places the attribute on each partial-property declaration, ideally including an edit with a reused driver, so future predicate changes cannot silently omit generated injection source.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!