Fix Mermaid label contrast in dark mode - #6531
Merged
Merged
Conversation
Dark-mode paragraph styling overrides Mermaid node colors, making labels on pastel nodes unreadable. Refs #6530
Greptile SummaryUpdates the lifecycle documentation and dark-mode Mermaid styling to restore node-specific label colors and improve initializer-label contrast.
Confidence Score: 5/5The PR appears safe to merge, with no concrete blocking or non-blocking defects identified in the changed code. The CSS selector is more specific than the global dark-mode paragraph rule and is scoped to Mermaid node labels, while the documentation color adjustment improves contrast without changing diagram behavior.
|
| Filename | Overview |
|---|---|
| docs/docs/writing-tests/lifecycle.md | Darkens the highlighted initializer node label while retaining the existing diagram structure and styling. |
| docs/src/css/custom.css | Adds a narrowly scoped dark-mode override so Mermaid node-label paragraphs inherit colors rather than receiving the global paragraph color. |
Reviews (1): Last reviewed commit: "fix(docs): restore Mermaid label contras..." | Re-trigger Greptile
This was referenced Aug 7, 2026
Open
This was referenced Aug 8, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The global dark-mode paragraph rule overrode colours inherited by Mermaid labels. This changed highlighted node text to
#cbd5e1, producing contrast as low as 1.05:1 on pastel backgrounds.The Mermaid-specific rule now preserves inherited node colours. The orange initializer label increases from 3.46:1 to 6.66:1 contrast.
Validation
yarn build(docs)git diff --checkAddresses discussion #6530.