chore(deps): update dependency microsoft.visualstudio.threading.analyzers to v18#6297
Conversation
There was a problem hiding this comment.
Code Review
This is a single-line dependency bump of Microsoft.VisualStudio.Threading.Analyzers from 17.14.15 → 18.7.23 in Directory.Packages.props.
Assessment: Looks good ✓
Risk is low — this is an analyzer-only package (compile-time tooling, no runtime dependency), so a major version bump carries far less risk than a runtime library upgrade. No production code changes, no API surface changes for consumers.
Notable improvements in v18 that are particularly relevant to TUnit:
- NativeAOT safety attributes added — TUnit has a hard requirement that all code must work with Native AOT. The new trim/NativeAOT annotations in the analyzer itself align well with this project goal.
- False-positive fixes — VSTHRD110 (expression-valued scenarios), VSTHRD103 (sync extension methods with async alternatives, superset fix), and VSTHRD114 (null in ternary conditionals) were all causing incorrect diagnostics. Fewer false positives means cleaner CI signal.
- Regex performance improvement — slow regex removed from the analyzers; marginally faster build times.
One thing to watch: The major version jump (17 → 18) may surface new or stricter analyzer warnings on existing code that previously went undiagnosed. If the build treats warnings-as-errors (common with Roslyn analyzers), this could cause a build failure. The pending CI runs will confirm — the modularpipeline matrix jobs across Linux/macOS/Windows are the right signal here.
No action needed beyond letting CI pass.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This PR contains the following updates:
17.14.15→18.7.23Release Notes
microsoft/vs-threading (Microsoft.VisualStudio.Threading.Analyzers)
v18.7.23What's Changed
Fixes
CancellationToken.Combinewith 3+ cancelable tokens by @AArnott in #1443Enhancements
JoinableTaskFactory.DisableProcessing()by @AArnott in #1576NoMessagePumpSyncContext..ctor(SynchronizationContext)for Post/Send behaviors by @AArnott in #1578IPendingExecutionRequestStateinterface to expose completion state ofSingleExecuteProtectorby @lifengl in #1447New Contributors
Full Changelog: microsoft/vs-threading@v17.14.15...v18.7.23
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate.