Skip to content

chore(deps): update dependency polyfill to 10.7.2#6148

Merged
thomhurst merged 1 commit into
mainfrom
renovate/polyfill-10.x
Jun 2, 2026
Merged

chore(deps): update dependency polyfill to 10.7.2#6148
thomhurst merged 1 commit into
mainfrom
renovate/polyfill-10.x

Conversation

@thomhurst
Copy link
Copy Markdown
Owner

This PR contains the following updates:

Package Type Update Change
Polyfill nuget patch 10.7.110.7.2

Release Notes

SimonCropp/Polyfill (Polyfill)

v10.7.2

Compare Source

  • #​552 Fix NET 8 CreateVersion7 polyfill RFC 9562/IETF variant bits

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate.

@thomhurst thomhurst added dependencies Pull requests that update a dependency file PATCH renovate-bot labels Jun 2, 2026
@thomhurst thomhurst enabled auto-merge (squash) June 2, 2026 05:41
@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This is a Renovate-generated patch bump of from → . The fix in 10.7.2 corrects incorrect variant bits in the polyfill on .NET 8 (RFC 9562 compliance). The change to Directory.Packages.props is correct.

Finding: TUnit.Core.targets not updated

File: TUnit.Core/TUnit.Core.targets, line 11

<_TUnitPolyfillVersion>10.7.1</_TUnitPolyfillVersion>

This property is still hardcoded to 10.7.1. The .targets file is shipped inside the TUnit.Core NuGet package and drives Polyfill auto-injection for downstream consumers targeting netstandard2.0, netstandard2.1, or .NETFramework. After this PR merges, those consumers will still receive the old buggy 10.7.1 version — the very version this bump intends to fix.

Both non-CPM users (line 17, explicit Version="$(_TUnitPolyfillVersion)") and CPM users without their own Polyfill pin (line 26, VersionOverride="$(_TUnitPolyfillVersion)") are affected.

Fix: bump the same property in TUnit.Core.targets:

<_TUnitPolyfillVersion>10.7.2</_TUnitPolyfillVersion>

Note: TUnit itself never calls Guid.CreateVersion7() (all internal Guid use is Guid.NewGuid() for transient IDs), so there is no correctness impact on TUnit's own test runs — but downstream consumers using TUnit on legacy TFMs could be silently pinned to the buggy polyfill.

Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This is a Renovate-generated patch bump of Polyfill from 10.7.1 to 10.7.2. The fix in 10.7.2 corrects incorrect variant bits in the Guid.CreateVersion7() polyfill on .NET 8 (RFC 9562 compliance). The change to Directory.Packages.props is correct.

Finding: TUnit.Core.targets not updated

File: TUnit.Core/TUnit.Core.targets, line 11

<_TUnitPolyfillVersion>10.7.1</_TUnitPolyfillVersion>

This property is still hardcoded to 10.7.1. The .targets file is shipped inside the TUnit.Core NuGet package and drives Polyfill auto-injection for downstream consumers targeting netstandard2.0, netstandard2.1, or .NETFramework. After this PR merges, those consumers will still receive the old buggy 10.7.1 version — the very version this bump intends to fix.

Both non-CPM users (line 17, explicit Version) and CPM users without their own Polyfill pin (line 26, VersionOverride) are affected by the stale version property.

Fix: bump the same property in TUnit.Core.targets:

<_TUnitPolyfillVersion>10.7.2</_TUnitPolyfillVersion>

Note: TUnit itself never calls Guid.CreateVersion7() — all internal Guid use is Guid.NewGuid() for transient IDs — so there is no correctness impact on TUnit's own test runs. But downstream consumers using TUnit on legacy TFMs will be silently pinned to the buggy polyfill until this is updated.

This was referenced Jun 4, 2026
intellitect-bot pushed a commit to IntelliTect/EssentialCSharp.Web that referenced this pull request Jun 4, 2026
Updated [TUnit](https://github.com/thomhurst/TUnit) from 1.48.6 to
1.49.0.

<details>
<summary>Release notes</summary>

_Sourced from [TUnit's
releases](https://github.com/thomhurst/TUnit/releases)._

## 1.49.0

<!-- Release notes generated using configuration in .github/release.yml
at v1.49.0 -->

## What's Changed
### Other Changes
* docs: benchmark page descriptions + promote Benchmarks in sidebar by
@​thomhurst in thomhurst/TUnit#6143
* feat(mocks): discriminate generic-method mocks by type argument by
@​thomhurst in thomhurst/TUnit#6153
* fix(source-gen): jagged array data fails to compile (#​6150) by
@​thomhurst in thomhurst/TUnit#6152
* fix: dispose shared fixtures when only a subset of consuming tests
runs by @​thomhurst in thomhurst/TUnit#6156
### Dependencies
* chore(deps): update tunit to 1.48.6 by @​thomhurst in
thomhurst/TUnit#6142
* chore(deps): update react to ^19.2.7 by @​thomhurst in
thomhurst/TUnit#6144
* chore(deps): update aspire to 13.4.0 by @​thomhurst in
thomhurst/TUnit#6145
* chore(deps): update dependency nunit.analyzers to 4.14.0 by
@​thomhurst in thomhurst/TUnit#6146
* chore(deps): update dependency polyfill to 10.7.2 by @​thomhurst in
thomhurst/TUnit#6148
* chore(deps): update dependency polyfill to 10.7.2 by @​thomhurst in
thomhurst/TUnit#6149
* chore(deps): update dependency dompurify to v3.4.8 by @​thomhurst in
thomhurst/TUnit#6155


**Full Changelog**:
thomhurst/TUnit@v1.48.6...v1.49.0

Commits viewable in [compare
view](thomhurst/TUnit@v1.48.6...v1.49.0).
</details>

Updated [TUnit.AspNetCore](https://github.com/thomhurst/TUnit) from
1.48.6 to 1.49.0.

<details>
<summary>Release notes</summary>

_Sourced from [TUnit.AspNetCore's
releases](https://github.com/thomhurst/TUnit/releases)._

## 1.49.0

<!-- Release notes generated using configuration in .github/release.yml
at v1.49.0 -->

## What's Changed
### Other Changes
* docs: benchmark page descriptions + promote Benchmarks in sidebar by
@​thomhurst in thomhurst/TUnit#6143
* feat(mocks): discriminate generic-method mocks by type argument by
@​thomhurst in thomhurst/TUnit#6153
* fix(source-gen): jagged array data fails to compile (#​6150) by
@​thomhurst in thomhurst/TUnit#6152
* fix: dispose shared fixtures when only a subset of consuming tests
runs by @​thomhurst in thomhurst/TUnit#6156
### Dependencies
* chore(deps): update tunit to 1.48.6 by @​thomhurst in
thomhurst/TUnit#6142
* chore(deps): update react to ^19.2.7 by @​thomhurst in
thomhurst/TUnit#6144
* chore(deps): update aspire to 13.4.0 by @​thomhurst in
thomhurst/TUnit#6145
* chore(deps): update dependency nunit.analyzers to 4.14.0 by
@​thomhurst in thomhurst/TUnit#6146
* chore(deps): update dependency polyfill to 10.7.2 by @​thomhurst in
thomhurst/TUnit#6148
* chore(deps): update dependency polyfill to 10.7.2 by @​thomhurst in
thomhurst/TUnit#6149
* chore(deps): update dependency dompurify to v3.4.8 by @​thomhurst in
thomhurst/TUnit#6155


**Full Changelog**:
thomhurst/TUnit@v1.48.6...v1.49.0

Commits viewable in [compare
view](thomhurst/TUnit@v1.48.6...v1.49.0).
</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file PATCH renovate-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants