chore(deps): update dependency polyfill to 10.7.2#6148
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Code Review
This is a Renovate-generated patch bump of from → . The fix in 10.7.2 corrects incorrect variant bits in the polyfill on .NET 8 (RFC 9562 compliance). The change to Directory.Packages.props is correct.
Finding: TUnit.Core.targets not updated
File: TUnit.Core/TUnit.Core.targets, line 11
<_TUnitPolyfillVersion>10.7.1</_TUnitPolyfillVersion>This property is still hardcoded to 10.7.1. The .targets file is shipped inside the TUnit.Core NuGet package and drives Polyfill auto-injection for downstream consumers targeting netstandard2.0, netstandard2.1, or .NETFramework. After this PR merges, those consumers will still receive the old buggy 10.7.1 version — the very version this bump intends to fix.
Both non-CPM users (line 17, explicit Version="$(_TUnitPolyfillVersion)") and CPM users without their own Polyfill pin (line 26, VersionOverride="$(_TUnitPolyfillVersion)") are affected.
Fix: bump the same property in TUnit.Core.targets:
<_TUnitPolyfillVersion>10.7.2</_TUnitPolyfillVersion>Note: TUnit itself never calls Guid.CreateVersion7() (all internal Guid use is Guid.NewGuid() for transient IDs), so there is no correctness impact on TUnit's own test runs — but downstream consumers using TUnit on legacy TFMs could be silently pinned to the buggy polyfill.
There was a problem hiding this comment.
Code Review
This is a Renovate-generated patch bump of Polyfill from 10.7.1 to 10.7.2. The fix in 10.7.2 corrects incorrect variant bits in the Guid.CreateVersion7() polyfill on .NET 8 (RFC 9562 compliance). The change to Directory.Packages.props is correct.
Finding: TUnit.Core.targets not updated
File: TUnit.Core/TUnit.Core.targets, line 11
<_TUnitPolyfillVersion>10.7.1</_TUnitPolyfillVersion>This property is still hardcoded to 10.7.1. The .targets file is shipped inside the TUnit.Core NuGet package and drives Polyfill auto-injection for downstream consumers targeting netstandard2.0, netstandard2.1, or .NETFramework. After this PR merges, those consumers will still receive the old buggy 10.7.1 version — the very version this bump intends to fix.
Both non-CPM users (line 17, explicit Version) and CPM users without their own Polyfill pin (line 26, VersionOverride) are affected by the stale version property.
Fix: bump the same property in TUnit.Core.targets:
<_TUnitPolyfillVersion>10.7.2</_TUnitPolyfillVersion>Note: TUnit itself never calls Guid.CreateVersion7() — all internal Guid use is Guid.NewGuid() for transient IDs — so there is no correctness impact on TUnit's own test runs. But downstream consumers using TUnit on legacy TFMs will be silently pinned to the buggy polyfill until this is updated.
Updated [TUnit](https://github.com/thomhurst/TUnit) from 1.48.6 to 1.49.0. <details> <summary>Release notes</summary> _Sourced from [TUnit's releases](https://github.com/thomhurst/TUnit/releases)._ ## 1.49.0 <!-- Release notes generated using configuration in .github/release.yml at v1.49.0 --> ## What's Changed ### Other Changes * docs: benchmark page descriptions + promote Benchmarks in sidebar by @thomhurst in thomhurst/TUnit#6143 * feat(mocks): discriminate generic-method mocks by type argument by @thomhurst in thomhurst/TUnit#6153 * fix(source-gen): jagged array data fails to compile (#6150) by @thomhurst in thomhurst/TUnit#6152 * fix: dispose shared fixtures when only a subset of consuming tests runs by @thomhurst in thomhurst/TUnit#6156 ### Dependencies * chore(deps): update tunit to 1.48.6 by @thomhurst in thomhurst/TUnit#6142 * chore(deps): update react to ^19.2.7 by @thomhurst in thomhurst/TUnit#6144 * chore(deps): update aspire to 13.4.0 by @thomhurst in thomhurst/TUnit#6145 * chore(deps): update dependency nunit.analyzers to 4.14.0 by @thomhurst in thomhurst/TUnit#6146 * chore(deps): update dependency polyfill to 10.7.2 by @thomhurst in thomhurst/TUnit#6148 * chore(deps): update dependency polyfill to 10.7.2 by @thomhurst in thomhurst/TUnit#6149 * chore(deps): update dependency dompurify to v3.4.8 by @thomhurst in thomhurst/TUnit#6155 **Full Changelog**: thomhurst/TUnit@v1.48.6...v1.49.0 Commits viewable in [compare view](thomhurst/TUnit@v1.48.6...v1.49.0). </details> Updated [TUnit.AspNetCore](https://github.com/thomhurst/TUnit) from 1.48.6 to 1.49.0. <details> <summary>Release notes</summary> _Sourced from [TUnit.AspNetCore's releases](https://github.com/thomhurst/TUnit/releases)._ ## 1.49.0 <!-- Release notes generated using configuration in .github/release.yml at v1.49.0 --> ## What's Changed ### Other Changes * docs: benchmark page descriptions + promote Benchmarks in sidebar by @thomhurst in thomhurst/TUnit#6143 * feat(mocks): discriminate generic-method mocks by type argument by @thomhurst in thomhurst/TUnit#6153 * fix(source-gen): jagged array data fails to compile (#6150) by @thomhurst in thomhurst/TUnit#6152 * fix: dispose shared fixtures when only a subset of consuming tests runs by @thomhurst in thomhurst/TUnit#6156 ### Dependencies * chore(deps): update tunit to 1.48.6 by @thomhurst in thomhurst/TUnit#6142 * chore(deps): update react to ^19.2.7 by @thomhurst in thomhurst/TUnit#6144 * chore(deps): update aspire to 13.4.0 by @thomhurst in thomhurst/TUnit#6145 * chore(deps): update dependency nunit.analyzers to 4.14.0 by @thomhurst in thomhurst/TUnit#6146 * chore(deps): update dependency polyfill to 10.7.2 by @thomhurst in thomhurst/TUnit#6148 * chore(deps): update dependency polyfill to 10.7.2 by @thomhurst in thomhurst/TUnit#6149 * chore(deps): update dependency dompurify to v3.4.8 by @thomhurst in thomhurst/TUnit#6155 **Full Changelog**: thomhurst/TUnit@v1.48.6...v1.49.0 Commits viewable in [compare view](thomhurst/TUnit@v1.48.6...v1.49.0). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This PR contains the following updates:
10.7.1→10.7.2Release Notes
SimonCropp/Polyfill (Polyfill)
v10.7.2Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate.