Skip to content

fix(sourcegen): fully-qualify Linq calls in params array binding (#6140) #6141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 3 commits into from
Jun 1, 2026
+119 −25
Merged

fix(sourcegen): fully-qualify Linq calls in params array binding (#6140) #6141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
822a0e8
fix(sourcegen): fully-qualify Linq calls in params array binding (#6140)
thomhurst Jun 1, 2026
e54f98d
test(sourcegen): regression test for params array Linq compilation (#…
thomhurst Jun 1, 2026
591b07d
docs(test): warn that injected global usings mask missing-using bugs …
thomhurst Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions TUnit.Core.SourceGenerator.Tests/ArgsAsArrayTests.Test.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// <auto-generated/>
// <auto-generated/>
#pragma warning disable

#nullable enable
Expand Down Expand Up @@ -106,7 +106,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(string[]), "names", ne
return default(global::System.Threading.Tasks.ValueTask);
}
default:
instance.Params((args.Length > 0 ? global::System.Linq.Enumerable.Range(0, args.Length).Select(i => global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[i])).ToArray() : new string[0]));
instance.Params((args.Length > 0 ? global::System.Linq.Enumerable.ToArray(global::System.Linq.Enumerable.Select(global::System.Linq.Enumerable.Range(0, args.Length), i => global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[i]))) : new string[0]));
return default(global::System.Threading.Tasks.ValueTask);
}
}
Expand Down Expand Up @@ -157,7 +157,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(string[]), "names", ne
return default(global::System.Threading.Tasks.ValueTask);
}
default:
instance.ParamsEnumerable((args.Length > 0 ? global::System.Linq.Enumerable.Range(0, args.Length).Select(i => global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[i])).ToArray() : new string[0]));
instance.ParamsEnumerable((args.Length > 0 ? global::System.Linq.Enumerable.ToArray(global::System.Linq.Enumerable.Select(global::System.Linq.Enumerable.Range(0, args.Length), i => global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[i]))) : new string[0]));
return default(global::System.Threading.Tasks.ValueTask);
}
}
Expand Down Expand Up @@ -212,7 +212,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(string[]), "names", ne
{
throw new global::System.ArgumentException($"Expected at least 1 argument, but got {args.Length}");
}
instance.Following_Non_Params(global::TUnit.Core.Helpers.CastHelper.Cast<int>(args[0]), (args.Length > 1 ? global::System.Linq.Enumerable.Range(1, args.Length - 1).Select(i => global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[i])).ToArray() : new string[0]));
instance.Following_Non_Params(global::TUnit.Core.Helpers.CastHelper.Cast<int>(args[0]), (args.Length > 1 ? global::System.Linq.Enumerable.ToArray(global::System.Linq.Enumerable.Select(global::System.Linq.Enumerable.Range(1, args.Length - 1), i => global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[i]))) : new string[0]));
return default(global::System.Threading.Tasks.ValueTask);
}
}
Expand Down Expand Up @@ -256,7 +256,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(string[]), "names", ne
return new global::System.Threading.Tasks.ValueTask(instance.NonParamsStringArray(new string[] { global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[0]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[1]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[2]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[3]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[4]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[5]) }));
}
default:
return new global::System.Threading.Tasks.ValueTask(instance.NonParamsStringArray((args.Length > 0 ? global::System.Linq.Enumerable.Range(0, args.Length).Select(i => global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[i])).ToArray() : new string[0])));
return new global::System.Threading.Tasks.ValueTask(instance.NonParamsStringArray((args.Length > 0 ? global::System.Linq.Enumerable.ToArray(global::System.Linq.Enumerable.Select(global::System.Linq.Enumerable.Range(0, args.Length), i => global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[i]))) : new string[0])));
}
}
catch (global::System.Exception ex)
Expand Down Expand Up @@ -299,7 +299,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(string[]), "names", ne
return new global::System.Threading.Tasks.ValueTask(instance.NonParamsStringArray_SingleValue(new string[] { global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[0]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[1]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[2]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[3]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[4]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[5]) }));
}
default:
return new global::System.Threading.Tasks.ValueTask(instance.NonParamsStringArray_SingleValue((args.Length > 0 ? global::System.Linq.Enumerable.Range(0, args.Length).Select(i => global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[i])).ToArray() : new string[0])));
return new global::System.Threading.Tasks.ValueTask(instance.NonParamsStringArray_SingleValue((args.Length > 0 ? global::System.Linq.Enumerable.ToArray(global::System.Linq.Enumerable.Select(global::System.Linq.Enumerable.Range(0, args.Length), i => global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[i]))) : new string[0])));
}
}
catch (global::System.Exception ex)
Expand Down Expand Up @@ -342,7 +342,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(string[]), "names", ne
return new global::System.Threading.Tasks.ValueTask(instance.NonParamsStringArray_MultipleValues(new string[] { global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[0]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[1]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[2]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[3]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[4]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[5]) }));
}
default:
return new global::System.Threading.Tasks.ValueTask(instance.NonParamsStringArray_MultipleValues((args.Length > 0 ? global::System.Linq.Enumerable.Range(0, args.Length).Select(i => global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[i])).ToArray() : new string[0])));
return new global::System.Threading.Tasks.ValueTask(instance.NonParamsStringArray_MultipleValues((args.Length > 0 ? global::System.Linq.Enumerable.ToArray(global::System.Linq.Enumerable.Select(global::System.Linq.Enumerable.Range(0, args.Length), i => global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[i]))) : new string[0])));
}
}
catch (global::System.Exception ex)
Expand Down Expand Up @@ -385,7 +385,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(string[]), "names", ne
return new global::System.Threading.Tasks.ValueTask(instance.NonParamsIntArray(new int[] { global::TUnit.Core.Helpers.CastHelper.Cast<int>(args[0]), global::TUnit.Core.Helpers.CastHelper.Cast<int>(args[1]), global::TUnit.Core.Helpers.CastHelper.Cast<int>(args[2]), global::TUnit.Core.Helpers.CastHelper.Cast<int>(args[3]), global::TUnit.Core.Helpers.CastHelper.Cast<int>(args[4]), global::TUnit.Core.Helpers.CastHelper.Cast<int>(args[5]) }));
}
default:
return new global::System.Threading.Tasks.ValueTask(instance.NonParamsIntArray((args.Length > 0 ? global::System.Linq.Enumerable.Range(0, args.Length).Select(i => global::TUnit.Core.Helpers.CastHelper.Cast<int>(args[i])).ToArray() : new int[0])));
return new global::System.Threading.Tasks.ValueTask(instance.NonParamsIntArray((args.Length > 0 ? global::System.Linq.Enumerable.ToArray(global::System.Linq.Enumerable.Select(global::System.Linq.Enumerable.Range(0, args.Length), i => global::TUnit.Core.Helpers.CastHelper.Cast<int>(args[i]))) : new int[0])));
}
}
catch (global::System.Exception ex)
Expand Down Expand Up @@ -428,7 +428,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(string[]), "names", ne
return new global::System.Threading.Tasks.ValueTask(instance.GenericStringArray(new string[] { global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[0]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[1]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[2]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[3]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[4]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[5]) }));
}
default:
return new global::System.Threading.Tasks.ValueTask(instance.GenericStringArray((args.Length > 0 ? global::System.Linq.Enumerable.Range(0, args.Length).Select(i => global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[i])).ToArray() : new string[0])));
return new global::System.Threading.Tasks.ValueTask(instance.GenericStringArray((args.Length > 0 ? global::System.Linq.Enumerable.ToArray(global::System.Linq.Enumerable.Select(global::System.Linq.Enumerable.Range(0, args.Length), i => global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[i]))) : new string[0])));
}
}
catch (global::System.Exception ex)
Expand Down Expand Up @@ -471,7 +471,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(string[]), "names", ne
return new global::System.Threading.Tasks.ValueTask(instance.NonParamsStringArray_BeyondStaticCaseCap(new string[] { global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[0]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[1]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[2]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[3]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[4]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[5]) }));
}
default:
return new global::System.Threading.Tasks.ValueTask(instance.NonParamsStringArray_BeyondStaticCaseCap((args.Length > 0 ? global::System.Linq.Enumerable.Range(0, args.Length).Select(i => global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[i])).ToArray() : new string[0])));
return new global::System.Threading.Tasks.ValueTask(instance.NonParamsStringArray_BeyondStaticCaseCap((args.Length > 0 ? global::System.Linq.Enumerable.ToArray(global::System.Linq.Enumerable.Select(global::System.Linq.Enumerable.Range(0, args.Length), i => global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[i]))) : new string[0])));
}
}
catch (global::System.Exception ex)
Expand Down
2 changes: 1 addition & 1 deletion ...ConflictingNamespaceTests.DataDrivenTest_WithConflictingNamespace.DotNet10_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(int), "value", new glo
return default(global::System.Threading.Tasks.ValueTask);
}
default:
instance.IntegerArray((args.Length > 0 ? global::System.Linq.Enumerable.Range(0, args.Length).Select(i => global::TUnit.Core.Helpers.CastHelper.Cast<int>(args[i])).ToArray() : new int[0]));
instance.IntegerArray((args.Length > 0 ? global::System.Linq.Enumerable.ToArray(global::System.Linq.Enumerable.Select(global::System.Linq.Enumerable.Range(0, args.Length), i => global::TUnit.Core.Helpers.CastHelper.Cast<int>(args[i]))) : new int[0]));
return default(global::System.Threading.Tasks.ValueTask);
}
}
Expand Down
2 changes: 1 addition & 1 deletion .../ConflictingNamespaceTests.DataDrivenTest_WithConflictingNamespace.DotNet8_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(int), "value", new glo
return default(global::System.Threading.Tasks.ValueTask);
}
default:
instance.IntegerArray((args.Length > 0 ? global::System.Linq.Enumerable.Range(0, args.Length).Select(i => global::TUnit.Core.Helpers.CastHelper.Cast<int>(args[i])).ToArray() : new int[0]));
instance.IntegerArray((args.Length > 0 ? global::System.Linq.Enumerable.ToArray(global::System.Linq.Enumerable.Select(global::System.Linq.Enumerable.Range(0, args.Length), i => global::TUnit.Core.Helpers.CastHelper.Cast<int>(args[i]))) : new int[0]));
return default(global::System.Threading.Tasks.ValueTask);
}
}
Expand Down
2 changes: 1 addition & 1 deletion .../ConflictingNamespaceTests.DataDrivenTest_WithConflictingNamespace.DotNet9_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(int), "value", new glo
return default(global::System.Threading.Tasks.ValueTask);
}
default:
instance.IntegerArray((args.Length > 0 ? global::System.Linq.Enumerable.Range(0, args.Length).Select(i => global::TUnit.Core.Helpers.CastHelper.Cast<int>(args[i])).ToArray() : new int[0]));
instance.IntegerArray((args.Length > 0 ? global::System.Linq.Enumerable.ToArray(global::System.Linq.Enumerable.Select(global::System.Linq.Enumerable.Range(0, args.Length), i => global::TUnit.Core.Helpers.CastHelper.Cast<int>(args[i]))) : new int[0]));
return default(global::System.Threading.Tasks.ValueTask);
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...sts/ConflictingNamespaceTests.DataDrivenTest_WithConflictingNamespace.Net4_7.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(int), "value", new glo
return default(global::System.Threading.Tasks.ValueTask);
}
default:
instance.IntegerArray((args.Length > 0 ? global::System.Linq.Enumerable.Range(0, args.Length).Select(i => global::TUnit.Core.Helpers.CastHelper.Cast<int>(args[i])).ToArray() : new int[0]));
instance.IntegerArray((args.Length > 0 ? global::System.Linq.Enumerable.ToArray(global::System.Linq.Enumerable.Select(global::System.Linq.Enumerable.Range(0, args.Length), i => global::TUnit.Core.Helpers.CastHelper.Cast<int>(args[i]))) : new int[0]));
return default(global::System.Threading.Tasks.ValueTask);
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...nflictingNamespaceTests.MethodDataSource_WithConflictingNamespace.DotNet10_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(string[]), "strings",
return new global::System.Threading.Tasks.ValueTask(instance.EnumerableFuncArrayTest(new string[] { global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[0]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[1]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[2]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[3]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[4]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[5]) }));
}
default:
return new global::System.Threading.Tasks.ValueTask(instance.EnumerableFuncArrayTest((args.Length > 0 ? global::System.Linq.Enumerable.Range(0, args.Length).Select(i => global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[i])).ToArray() : new string[0])));
return new global::System.Threading.Tasks.ValueTask(instance.EnumerableFuncArrayTest((args.Length > 0 ? global::System.Linq.Enumerable.ToArray(global::System.Linq.Enumerable.Select(global::System.Linq.Enumerable.Range(0, args.Length), i => global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[i]))) : new string[0])));
}
}
catch (global::System.Exception ex)
Expand Down
2 changes: 1 addition & 1 deletion ...onflictingNamespaceTests.MethodDataSource_WithConflictingNamespace.DotNet8_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(string[]), "strings",
return new global::System.Threading.Tasks.ValueTask(instance.EnumerableFuncArrayTest(new string[] { global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[0]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[1]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[2]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[3]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[4]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[5]) }));
}
default:
return new global::System.Threading.Tasks.ValueTask(instance.EnumerableFuncArrayTest((args.Length > 0 ? global::System.Linq.Enumerable.Range(0, args.Length).Select(i => global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[i])).ToArray() : new string[0])));
return new global::System.Threading.Tasks.ValueTask(instance.EnumerableFuncArrayTest((args.Length > 0 ? global::System.Linq.Enumerable.ToArray(global::System.Linq.Enumerable.Select(global::System.Linq.Enumerable.Range(0, args.Length), i => global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[i]))) : new string[0])));
}
}
catch (global::System.Exception ex)
Expand Down
2 changes: 1 addition & 1 deletion ...onflictingNamespaceTests.MethodDataSource_WithConflictingNamespace.DotNet9_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(string[]), "strings",
return new global::System.Threading.Tasks.ValueTask(instance.EnumerableFuncArrayTest(new string[] { global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[0]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[1]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[2]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[3]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[4]), global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[5]) }));
}
default:
return new global::System.Threading.Tasks.ValueTask(instance.EnumerableFuncArrayTest((args.Length > 0 ? global::System.Linq.Enumerable.Range(0, args.Length).Select(i => global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[i])).ToArray() : new string[0])));
return new global::System.Threading.Tasks.ValueTask(instance.EnumerableFuncArrayTest((args.Length > 0 ? global::System.Linq.Enumerable.ToArray(global::System.Linq.Enumerable.Select(global::System.Linq.Enumerable.Range(0, args.Length), i => global::TUnit.Core.Helpers.CastHelper.Cast<string>(args[i]))) : new string[0])));
}
}
catch (global::System.Exception ex)
Expand Down
Loading
Loading