Skip to content

perf: hoist char[] alloc in FsCheckPropertyTestExecutor to static SearchValues #6108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 2 commits into from
May 28, 2026
+8 −0
Merged

perf: hoist char[] alloc in FsCheckPropertyTestExecutor to static SearchValues #6108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d32b8f
perf: hoist char[] alloc in FsCheckPropertyTestExecutor to static Sea…
thomhurst May 28, 2026
b77b9c1
style: rename LineEndings field to _lineEndings for convention
thomhurst May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions TUnit.FsCheck/FsCheckPropertyTestExecutor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ namespace TUnit.FsCheck;
#pragma warning disable IL2072 // DynamicallyAccessedMembers warning
public class FsCheckPropertyTestExecutor : ITestExecutor
{
#if NET8_0_OR_GREATER
private static readonly System.Buffers.SearchValues<char> _lineEndings = System.Buffers.SearchValues.Create("\r\n");
#endif

private readonly FsCheckPropertyAttribute _propertyAttribute;

public FsCheckPropertyTestExecutor(FsCheckPropertyAttribute propertyAttribute)
Expand Down Expand Up @@ -192,7 +196,11 @@ private static string FormatCounterexample(MethodInfo methodInfo, Exception ex)
var afterShrunk = message[(shrunkIndex + 7)..].TrimStart();

// Take only the first line
#if NET8_0_OR_GREATER
var newlineIndex = afterShrunk.AsSpan().IndexOfAny(_lineEndings);
#else
var newlineIndex = afterShrunk.IndexOfAny(['\r', '\n']);
#endif
var shrunkLine = newlineIndex >= 0 ? afterShrunk[..newlineIndex] : afterShrunk;

if (shrunkLine.StartsWith('('))
Expand Down
Loading