Skip to content

perf: replace LINQ dependency extraction with manual loop #6096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 2 commits into from
May 28, 2026
+33 −5
Merged

perf: replace LINQ dependency extraction with manual loop #6096

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89b331e
perf: replace LINQ dependency extraction with manual loop
thomhurst May 28, 2026
a461e9e
refactor: share ExtractDependencies across dynamic-discovery paths
thomhurst May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion TUnit.Engine/Building/Collectors/AotTestDataCollector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ private Task<TestMetadata> CreateMetadataFromDynamicDiscoveryResult(DynamicDisco
TestName = testName,
TestClassType = result.TestClassType,
TestMethodName = methodInfo.Name,
Dependencies = result.Attributes.OfType<DependsOnAttribute>().Select(a => a.ToTestDependency()).ToArray(),
Dependencies = ExtractDependencies(result.Attributes),
DataSources = [], // Dynamic tests don't use data sources in the same way
ClassDataSources = [],
PropertyDataSources = [],
Expand All @@ -286,6 +286,21 @@ private Task<TestMetadata> CreateMetadataFromDynamicDiscoveryResult(DynamicDisco
});
}

private static TestDependency[] ExtractDependencies(List<Attribute> attributes)
{
List<TestDependency>? dependencies = null;

foreach (var attribute in attributes)
{
if (attribute is DependsOnAttribute dependsOn)
{
(dependencies ??= []).Add(dependsOn.ToTestDependency());
}
}

return dependencies?.ToArray() ?? [];
}

private static Attribute[] GetDynamicTestAttributes(DynamicDiscoveryResult result)
{
if (result.TestClassType == null)
Expand Down
17 changes: 16 additions & 1 deletion TUnit.Engine/Discovery/ReflectionTestDataCollector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2229,7 +2229,7 @@ private Task<TestMetadata> CreateMetadataFromDynamicDiscoveryResult(DynamicDisco
TestName = testName,
TestClassType = result.TestClassType,
TestMethodName = methodInfo.Name,
Dependencies = result.Attributes.OfType<DependsOnAttribute>().Select(static a => a.ToTestDependency()).ToArray(),
Dependencies = ExtractDependencies(result.Attributes),
DataSources = [], // Dynamic tests don't use data sources in the same way
ClassDataSources = [],
PropertyDataSources = [],
Expand All @@ -2248,6 +2248,21 @@ private Task<TestMetadata> CreateMetadataFromDynamicDiscoveryResult(DynamicDisco
return Task.FromResult<TestMetadata>(metadata);
}

private static TestDependency[] ExtractDependencies(List<Attribute> attributes)
{
List<TestDependency>? dependencies = null;

foreach (var attribute in attributes)
{
if (attribute is DependsOnAttribute dependsOn)
{
(dependencies ??= []).Add(dependsOn.ToTestDependency());
}
}

return dependencies?.ToArray() ?? [];
}

private static Attribute[] GetDynamicTestAttributes(DynamicDiscoveryResult result)
{
if (result.TestClassType == null)
Expand Down
Loading