Skip to content

perf: optimize TestNameFormatter argument and bool formatting #6095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
May 28, 2026
Merged

perf: optimize TestNameFormatter argument and bool formatting #6095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions TUnit.Core/Services/TestNameFormatter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public string FormatArgumentValue(object? value)
null => "null",
string str => $"\"{str}\"",
char ch => $"'{ch}'",
bool b => b.ToString().ToLowerInvariant(),
bool b => b ? "true" : "false",
// Use InvariantCulture for numeric types to avoid culture-specific formatting issues
double d => d.ToString(System.Globalization.CultureInfo.InvariantCulture),
float f => f.ToString(System.Globalization.CultureInfo.InvariantCulture),
Expand Down Expand Up @@ -95,7 +95,26 @@ private string FormatArguments(object?[] args)
return string.Empty;
}

return string.Join(", ", args.Select(FormatArgumentValue));
// Build directly into a pooled StringBuilder to avoid the LINQ iterator/closure
// and the temporary string[] that Select + string.Join would materialize.
var builder = StringBuilderPool.Get();
try
{
for (var i = 0; i < args.Length; i++)
{
if (i > 0)
{
builder.Append(", ");
}
builder.Append(FormatArgumentValue(args[i]));
}

return builder.ToString();
}
finally
{
StringBuilderPool.Return(builder);
}
}

private string FormatEnumerable(IEnumerable enumerable)
Expand Down
Loading