Skip to content

perf: use EnumerateLines for line splitting in HtmlReportGenerator #6089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 2 commits into from
May 28, 2026
Merged

perf: use EnumerateLines for line splitting in HtmlReportGenerator #6089

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a6a4aa
perf: use EnumerateLines for line splitting in HtmlReportGenerator
thomhurst May 28, 2026
2ca4bc4
perf: early-exit TryExtractExpectedActual once both values found
thomhurst May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 38 additions & 1 deletion TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,6 +672,27 @@ private static void TryExtractExpectedActual(string message, out string? expecte
expected = null;
actual = null;
if (string.IsNullOrEmpty(message)) return;
#if NET
// EnumerateLines splits on \n and \r\n natively — no Replace/Split allocations.
foreach (var rawLine in message.AsSpan().EnumerateLines())
{
var line = rawLine.TrimStart();
if (expected is null && line.StartsWith("Expected:", StringComparison.OrdinalIgnoreCase))
{
expected = line.Slice("Expected:".Length).Trim().ToString();
}
else if (actual is null && (line.StartsWith("Actual:", StringComparison.OrdinalIgnoreCase) || line.StartsWith("But was:", StringComparison.OrdinalIgnoreCase)))
{
var prefixLen = line.StartsWith("Actual:", StringComparison.OrdinalIgnoreCase) ? "Actual:".Length : "But was:".Length;
actual = line.Slice(prefixLen).Trim().ToString();
}

if (expected is not null && actual is not null)
{
break;
}
}
#else
var lines = message.Replace("\r\n", "\n").Split('\n');
foreach (var raw in lines)
{
Expand All @@ -685,7 +706,13 @@ private static void TryExtractExpectedActual(string message, out string? expecte
var prefixLen = line.StartsWith("Actual:", StringComparison.OrdinalIgnoreCase) ? "Actual:".Length : "But was:".Length;
actual = line.Substring(prefixLen).Trim();
}

if (expected is not null && actual is not null)
{
break;
}
}
#endif
if (expected is { Length: 0 }) expected = null;
if (actual is { Length: 0 }) actual = null;
}
Expand Down Expand Up @@ -767,14 +794,24 @@ private static bool IsDuplicateKey(ReportKeyValue[] items, int index, string key
{
if (string.IsNullOrEmpty(stderr)) return stderr;
if (stderr!.IndexOf("[TUnit]", StringComparison.Ordinal) < 0) return stderr;
var lines = stderr.Replace("\r\n", "\n").Split('\n');
var sb = new StringBuilder(stderr.Length);
#if NET
// EnumerateLines splits on \n and \r\n natively — no Replace/Split allocations.
foreach (var line in stderr.AsSpan().EnumerateLines())
{
if (line.TrimStart().StartsWith("[TUnit]", StringComparison.Ordinal)) continue;
if (sb.Length > 0) sb.Append('\n');
sb.Append(line);
}
#else
var lines = stderr.Replace("\r\n", "\n").Split('\n');
foreach (var line in lines)
{
if (line.TrimStart().StartsWith("[TUnit]", StringComparison.Ordinal)) continue;
if (sb.Length > 0) sb.Append('\n');
sb.Append(line);
}
#endif
return sb.Length == 0 ? null : sb.ToString();
}

Expand Down
Loading